* [pve-devel] [PATCH manager] ui: reset UI state on automatic logout
@ 2026-01-13 12:01 Dominik Csapak
2026-01-13 18:20 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-01-13 12:01 UTC (permalink / raw)
To: pve-devel
when clicking the 'Logout' button, the UI state resets such that the
resource tree gets cleared out, the ClusterName is deleted and the
current panel gets removed.
In contrast, when automatically logged out (e.g. the ticket was
invalid), we only showed the login mask over the current state.
To make it more consistent, also reset the state when automatically
logged out. This fixes showing (possibly sensitive) data when the user
is actually logged out.
Since the navigation state is saved in the fragment, when the user logs
in again, the last used panel is automatically loaded again.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/Workspace.js | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index ce7ea21f..3d3b5f62 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -55,6 +55,11 @@ Ext.define('PVE.Workspace', {
}
me.onLogin(null);
me.login.show();
+
+ // reset ui state
+ PVE.ClusterName = undefined;
+ me.down('pveResourceTree')?.clearTree();
+ me.setContent(null);
},
initComponent: function () {
@@ -450,10 +455,6 @@ Ext.define('PVE.StdWorkspace', {
handler: function () {
PVE.data.ResourceStore.loadData([], false);
me.showLogin();
- me.setContent(null);
- var rt = me.down('pveResourceTree');
- PVE.ClusterName = undefined;
- rt.clearTree();
// empty the stores of the StatusPanel child items
var statusPanels =
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pve-devel] [PATCH manager] ui: reset UI state on automatic logout
2026-01-13 12:01 [pve-devel] [PATCH manager] ui: reset UI state on automatic logout Dominik Csapak
@ 2026-01-13 18:20 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-01-13 18:20 UTC (permalink / raw)
To: pve-devel, Dominik Csapak
On Tue, 13 Jan 2026 13:01:06 +0100, Dominik Csapak wrote:
> when clicking the 'Logout' button, the UI state resets such that the
> resource tree gets cleared out, the ClusterName is deleted and the
> current panel gets removed.
>
> In contrast, when automatically logged out (e.g. the ticket was
> invalid), we only showed the login mask over the current state.
>
> [...]
Applied, but reworded the commit message slightly (I know I already reviewed it
offlist, but noticed something only now), thanks!
[1/1] ui: reset UI state on automatic logout
commit: 88af658c17f8f69fbe6748c5daf3db6f38cf80e0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-13 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-13 12:01 [pve-devel] [PATCH manager] ui: reset UI state on automatic logout Dominik Csapak
2026-01-13 18:20 ` Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.