From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH ha-manager] resources: assert ha resource has correct guest type
Date: Tue, 13 Jan 2026 14:42:54 +0100 [thread overview]
Message-ID: <176831164865.132583.8819684256163458584.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260112101728.162151-1-d.kral@proxmox.com>
On Mon, 12 Jan 2026 11:16:49 +0100, Daniel Kral wrote:
> Otherwise a HA resource with the wrong guest type can be added to the HA
> resources configuration, which will make its methods (start, shutdown,
> migrate, ...) fail.
>
> This does not fixup existing HA resource entries with the wrong guest
> type, but manual removal, e.g., through `ha-manager remove <sid>` and
> re-adding it correctly, is still possible.
>
> [...]
Applied with Michael's R-b and T-b, thanks! I slightly changed the
error message to
resource 'ct:$vmid' - guest with ID $vmid is not a container
just to avoid any potential for confusion (stating "ct:something is
not a ct" can sound a bit off).
[1/1] resources: assert ha resource has correct guest type
commit: 18b3b0950c04a8aaeb1b6a406a13f437ac6e7792
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2026-01-13 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 10:16 [pve-devel] " Daniel Kral
2026-01-12 16:24 ` Michael Köppl
2026-01-13 13:42 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176831164865.132583.8819684256163458584.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.