[pbs-devel] [PATCH proxmox-backup v2 1/1] fix: s3: make s3_refresh apihandler sync

[pbs-devel] [PATCH proxmox-backup v2 1/1] fix: s3: make s3_refresh apihandler sync

[Nicolas Frey]

fixes regression from 524cf1e7 that made `datastore::s3_refresh` sync
but did not change the ApiHandler matching part here

This would result in a panic every time an s3-refresh was initiated

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
Fixes: 524cf1e7 ("api: admin: make s3 refresh handler sync") 
Fixes: https://forum.proxmox.com/threads/178655
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
added Fixes trailer to reference blamed commit

 src/bin/proxmox_backup_manager/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
index 57b4ca29..5c65c5ec 100644
--- a/src/bin/proxmox_backup_manager/datastore.rs
+++ b/src/bin/proxmox_backup_manager/datastore.rs
@@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
 
     let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
     let result = match info.handler {
-        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
+        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
         _ => unreachable!(),
     };
 
-- 
2.47.3


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup v2 1/1] fix: s3: make s3_refresh apihandler sync

[Fabian Grünbichler]

On Wed, 07 Jan 2026 13:46:04 +0100, Nicolas Frey wrote:
> fixes regression from 524cf1e7 that made `datastore::s3_refresh` sync
> but did not change the ApiHandler matching part here
> 
> This would result in a panic every time an s3-refresh was initiated
> 
> 

Applied, thanks!

[1/1] fix: s3: make s3_refresh apihandler sync
      commit: 75d9dd1279ee28a25608a37e62fd5897dd7a3220

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel