[pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Shannon Sterz]

TextRenderFn has been removed from proxmox-yew-widget-toolkit
recently. use the generic RenderFn instead.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---

note that this should only be applied once proxmox-yew-widget-toolkit
has been bumped. this isn't yet an issue, but i didn't find a patch for
this on list yet. hence, i'm sending this now so that it isn't
forgotten.

 ui/src/main.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/ui/src/main.rs b/ui/src/main.rs
index 5f859db..2bd900e 100644
--- a/ui/src/main.rs
+++ b/ui/src/main.rs
@@ -7,7 +7,7 @@ use web_sys::HtmlElement;
 use yew::prelude::*;

 use pwt::prelude::*;
-use pwt::props::TextRenderFn;
+use pwt::props::RenderFn;
 use pwt::state::{Loader, PersistentState, SharedStateObserver};
 use pwt::widget::{Column, DesktopApp, Dialog, Mask};
 use pwt::AsyncPool;
@@ -346,9 +346,7 @@ impl Component for DatacenterManagerApp {
                 </ContextProvider<RemoteList>>
             </ContextProvider<SearchProvider>>
         })
-        .catalog_url_builder(TextRenderFn::new(|lang| {
-            format!("locale/catalog-{lang}.mo")
-        }))
+        .catalog_url_builder(RenderFn::new(|lang| format!("locale/catalog-{lang}.mo")))
         .into()
     }
 }
--
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Dominik Csapak]

thanks for sending this, wanted to do later, but did not get around to 
it yet!

Consider this

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

(I'm purposely not applying this right now since pwt is not yet bumped)


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Shannon Sterz]

ping, pwt has been bumped and pdm ui master is currently broken.

On Thu Dec 11, 2025 at 11:10 AM CET, Shannon Sterz wrote:
> TextRenderFn has been removed from proxmox-yew-widget-toolkit
> recently. use the generic RenderFn instead.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>
> note that this should only be applied once proxmox-yew-widget-toolkit
> has been bumped. this isn't yet an issue, but i didn't find a patch for
> this on list yet. hence, i'm sending this now so that it isn't
> forgotten.
>
>  ui/src/main.rs | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/ui/src/main.rs b/ui/src/main.rs
> index 5f859db..2bd900e 100644
> --- a/ui/src/main.rs
> +++ b/ui/src/main.rs
> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
>  use yew::prelude::*;
>
>  use pwt::prelude::*;
> -use pwt::props::TextRenderFn;
> +use pwt::props::RenderFn;
>  use pwt::state::{Loader, PersistentState, SharedStateObserver};
>  use pwt::widget::{Column, DesktopApp, Dialog, Mask};
>  use pwt::AsyncPool;
> @@ -346,9 +346,7 @@ impl Component for DatacenterManagerApp {
>                  </ContextProvider<RemoteList>>
>              </ContextProvider<SearchProvider>>
>          })
> -        .catalog_url_builder(TextRenderFn::new(|lang| {
> -            format!("locale/catalog-{lang}.mo")
> -        }))
> +        .catalog_url_builder(RenderFn::new(|lang| format!("locale/catalog-{lang}.mo")))
>          .into()
>      }
>  }
> --
> 2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Shannon Sterz]

Superseded-by: https://lore.proxmox.com/all/20251219123758.151318-2-s.sterz@proxmox.com/T/#t

On Thu Dec 11, 2025 at 11:10 AM CET, Shannon Sterz wrote:
> TextRenderFn has been removed from proxmox-yew-widget-toolkit
> recently. use the generic RenderFn instead.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>
> note that this should only be applied once proxmox-yew-widget-toolkit
> has been bumped. this isn't yet an issue, but i didn't find a patch for
> this on list yet. hence, i'm sending this now so that it isn't
> forgotten.
>
>  ui/src/main.rs | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/ui/src/main.rs b/ui/src/main.rs
> index 5f859db..2bd900e 100644
> --- a/ui/src/main.rs
> +++ b/ui/src/main.rs
> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
>  use yew::prelude::*;
>
>  use pwt::prelude::*;
> -use pwt::props::TextRenderFn;
> +use pwt::props::RenderFn;
>  use pwt::state::{Loader, PersistentState, SharedStateObserver};
>  use pwt::widget::{Column, DesktopApp, Dialog, Mask};
>  use pwt::AsyncPool;
> @@ -346,9 +346,7 @@ impl Component for DatacenterManagerApp {
>                  </ContextProvider<RemoteList>>
>              </ContextProvider<SearchProvider>>
>          })
> -        .catalog_url_builder(TextRenderFn::new(|lang| {
> -            format!("locale/catalog-{lang}.mo")
> -        }))
> +        .catalog_url_builder(RenderFn::new(|lang| format!("locale/catalog-{lang}.mo")))
>          .into()
>      }
>  }
> --
> 2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Shannon Sterz]

On Fri Dec 19, 2025 at 1:40 PM CET, Shannon Sterz wrote:
> Superseded-by: https://lore.proxmox.com/all/20251219123758.151318-2-s.sterz@proxmox.com/T/#t

sorry ignore this, this is still the current and correct fix. the series
linked to above is for something else

>
> On Thu Dec 11, 2025 at 11:10 AM CET, Shannon Sterz wrote:
>> TextRenderFn has been removed from proxmox-yew-widget-toolkit
>> recently. use the generic RenderFn instead.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>
>> note that this should only be applied once proxmox-yew-widget-toolkit
>> has been bumped. this isn't yet an issue, but i didn't find a patch for
>> this on list yet. hence, i'm sending this now so that it isn't
>> forgotten.
>>
>>  ui/src/main.rs | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/ui/src/main.rs b/ui/src/main.rs
>> index 5f859db..2bd900e 100644
>> --- a/ui/src/main.rs
>> +++ b/ui/src/main.rs
>> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
>>  use yew::prelude::*;
>>
>>  use pwt::prelude::*;
>> -use pwt::props::TextRenderFn;
>> +use pwt::props::RenderFn;
>>  use pwt::state::{Loader, PersistentState, SharedStateObserver};
>>  use pwt::widget::{Column, DesktopApp, Dialog, Mask};
>>  use pwt::AsyncPool;
>> @@ -346,9 +346,7 @@ impl Component for DatacenterManagerApp {
>>                  </ContextProvider<RemoteList>>
>>              </ContextProvider<SearchProvider>>
>>          })
>> -        .catalog_url_builder(TextRenderFn::new(|lang| {
>> -            format!("locale/catalog-{lang}.mo")
>> -        }))
>> +        .catalog_url_builder(RenderFn::new(|lang| format!("locale/catalog-{lang}.mo")))
>>          .into()
>>      }
>>  }
>> --
>> 2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn

[Fabian Grünbichler]

On Thu, 11 Dec 2025 11:10:30 +0100, Shannon Sterz wrote:
> TextRenderFn has been removed from proxmox-yew-widget-toolkit
> recently. use the generic RenderFn instead.
> 
> 

Applied, thanks!

[1/1] ui: use RenderFn instead of TextRenderFn
      commit: f5f833694049dce322dcbfd8bf1c015bc99833cb

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel