all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH yew-comp] wizard: prevent page reload when pressing enter in form
@ 2025-12-11 13:32 Dominik Csapak
  2025-12-16 11:52 ` [pdm-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-12-11 13:32 UTC (permalink / raw)
  To: pdm-devel

When pressing enter while the focus is inside a `Form` element, the
browser tries to submit the form, and the default method is to send the
data to the page via GET parameters.

This can lead to unwanted refreshes, e.g. in PDM the remote wizard would
change the url from
 https://<hostname>:8443/#/
to
 https://<hostname>:8443/?#/

which refreshed the page.

To prevent that, use `event.prevent_default()` in the onsubmit handler,
since we handle submitting the data ourselves there.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/wizard.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/wizard.rs b/src/wizard.rs
index 802a816..7d83da1 100644
--- a/src/wizard.rs
+++ b/src/wizard.rs
@@ -524,7 +524,8 @@ impl Component for PwtWizard {
                 .form_context(form_ctx.clone())
                 .onsubmit(ctx.link().batch_callback({
                     let state = self.controller.clone();
-                    move |_| {
+                    move |event: SubmitEvent| {
+                        event.prevent_default(); // don't reload the page
                         if !state.read().can_progress() {
                             return None;
                         }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pdm-devel] applied: [PATCH yew-comp] wizard: prevent page reload when pressing enter in form
  2025-12-11 13:32 [pdm-devel] [PATCH yew-comp] wizard: prevent page reload when pressing enter in form Dominik Csapak
@ 2025-12-16 11:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-16 11:52 UTC (permalink / raw)
  To: pdm-devel, Dominik Csapak

On Thu, 11 Dec 2025 14:32:15 +0100, Dominik Csapak wrote:
> When pressing enter while the focus is inside a `Form` element, the
> browser tries to submit the form, and the default method is to send the
> data to the page via GET parameters.
> 
> This can lead to unwanted refreshes, e.g. in PDM the remote wizard would
> change the url from
>  https://<hostname>:8443/#/
> to
>  https://<hostname>:8443/?#/
> 
> [...]

Applied, thanks!

[1/1] wizard: prevent page reload when pressing enter in form
      commit: 563c232dc439c1bbafba0811dfd382293755b6b2


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-16 11:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-11 13:32 [pdm-devel] [PATCH yew-comp] wizard: prevent page reload when pressing enter in form Dominik Csapak
2025-12-16 11:52 ` [pdm-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal