* [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix button classes
@ 2025-12-09 7:40 Dominik Csapak
2025-12-09 8:14 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-12-09 7:40 UTC (permalink / raw)
To: pve-devel
commit
54a2e41 (RRD metric type selector: adapt applying CSS class to fix ExtJS debug mode)
changed how the item classes are set, but included a typo.
This was fixed in
f7e555b (RRD metric type selector: fix typo)
but not completely (the property is 'defaults', not 'default'), so use
the correct one.
Fixes: 54a2e41 (RRD metric type selector: adapt applying CSS class to fix ExtJS debug mode)
Fixes: f7e555b (RRD metric type selector: fix typo)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/form/RRDTypeSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js
index 3c1cb5e..b6e0124 100644
--- a/src/form/RRDTypeSelector.js
+++ b/src/form/RRDTypeSelector.js
@@ -75,7 +75,7 @@ Ext.define('Proxmox.form.RRDTypeSelector', {
xtype: 'segmentedbutton',
allowMultiple: false,
allowToggle: true,
- default: {
+ defaults: {
cls: 'x-btn-default-toolbar-small proxmox-inline-button',
},
items: [
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix button classes
2025-12-09 7:40 [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix button classes Dominik Csapak
@ 2025-12-09 8:14 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-09 8:14 UTC (permalink / raw)
To: pve-devel, Dominik Csapak
On Tue, 09 Dec 2025 08:40:22 +0100, Dominik Csapak wrote:
> commit
> 54a2e41 (RRD metric type selector: adapt applying CSS class to fix ExtJS debug mode)
>
> changed how the item classes are set, but included a typo.
> This was fixed in
> f7e555b (RRD metric type selector: fix typo)
> but not completely (the property is 'defaults', not 'default'), so use
> the correct one.
>
> [...]
Applied, thanks!
[1/1] RRDTypeSelector: fix button classes
commit: f13a3667cec88a13c92818c51ee5d652344061d1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-09 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-09 7:40 [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix button classes Dominik Csapak
2025-12-09 8:14 ` Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.