all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH proxmox 1/1] access-control: allow first / last name with one character
@ 2025-12-02 14:39 Stefan Hanreich
  2025-12-03 12:22 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hanreich @ 2025-12-02 14:39 UTC (permalink / raw)
  To: pdm-devel

In Proxmox VE we already allow creating users with a single character
as first / last name. There's real first / last names that consist of
only a letter, so do not restrict this here.

Reported-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Not sure about possible ramifications with realms other than PAM / PDM
PBS, but tested with the built-in realms and didn't encounter any
problems.

 proxmox-access-control/src/types.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-access-control/src/types.rs b/proxmox-access-control/src/types.rs
index 85b1f106..78eafb4c 100644
--- a/proxmox-access-control/src/types.rs
+++ b/proxmox-access-control/src/types.rs
@@ -24,13 +24,13 @@ pub const EXPIRE_USER_SCHEMA: Schema = IntegerSchema::new(
 
 pub const FIRST_NAME_SCHEMA: Schema = StringSchema::new("First name.")
     .format(&SINGLE_LINE_COMMENT_FORMAT)
-    .min_length(2)
+    .min_length(1)
     .max_length(64)
     .schema();
 
 pub const LAST_NAME_SCHEMA: Schema = StringSchema::new("Last name.")
     .format(&SINGLE_LINE_COMMENT_FORMAT)
-    .min_length(2)
+    .min_length(1)
     .max_length(64)
     .schema();
 
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pdm-devel] [PATCH proxmox 1/1] access-control: allow first / last name with one character
  2025-12-02 14:39 [pdm-devel] [PATCH proxmox 1/1] access-control: allow first / last name with one character Stefan Hanreich
@ 2025-12-03 12:22 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-12-03 12:22 UTC (permalink / raw)
  To: pdm-devel, Stefan Hanreich

On Tue, 02 Dec 2025 15:39:32 +0100, Stefan Hanreich wrote:
> In Proxmox VE we already allow creating users with a single character
> as first / last name. There's real first / last names that consist of
> only a letter, so do not restrict this here.
> 
> 

Applied, thanks!

[1/1] access-control: allow first / last name with one character
      commit: e46a17a0b3c1d817db92be116ba30800dea579fc


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-03 12:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-02 14:39 [pdm-devel] [PATCH proxmox 1/1] access-control: allow first / last name with one character Stefan Hanreich
2025-12-03 12:22 ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal