From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: [pdm-devel] applied: [PATCH proxmox] pve-api-types: schema2rust: don't mark URL parameters as optional
Date: Mon, 1 Dec 2025 04:29:05 +0100 [thread overview]
Message-ID: <176455974535.2674830.678183661526707545.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251128080733.43974-1-h.laimer@proxmox.com>
On Fri, 28 Nov 2025 09:07:33 +0100, Hannes Laimer wrote:
> When a URL path parameter (e.g. .../rules/{pos}) shares a name with a schema
> field that is marked as optional, the generator incorrectly wrapped the
> path parameter in `Option<T>`.
>
> Remove the logic that applies the schema's optionality to URL parameters,
> ensuring they are always generated as required types.
>
> [...]
Applied, thanks!
[1/1] pve-api-types: schema2rust: don't mark URL parameters as optional
commit: 2f33df3aa4c8f2d18af21d6ad9b5ad42ac456a3c
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-01 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 8:07 [pdm-devel] " Hannes Laimer
2025-12-01 3:29 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176455974535.2674830.678183661526707545.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.