From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox 3/5] proxmox-fixed-string: implement hash trait
Date: Mon, 1 Dec 2025 04:29:08 +0100 [thread overview]
Message-ID: <176455974534.2674830.9440539080891494681.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251120145031.550340-4-s.hanreich@proxmox.com>
On Thu, 20 Nov 2025 15:50:11 +0100, Stefan Hanreich wrote:
> Some enums in pbs-api-types implement Hash, so FixedString needs to
> implement it too in order to be usable there.
>
> While it should have been fine to use the whole struct here because
> the buffer is zeroed on construction and the length is constant for
> equal strings - still only use the actual bytes from the buffer that
> contain the current string to avoid potential shenanigans.
>
> [...]
Applied, thanks!
[3/5] proxmox-fixed-string: implement hash trait
commit: 762753cf1513dc166478e43529b3141e83efc1a0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-12-01 3:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 14:50 [pbs-devel] [RFC proxmox{, -datacenter-manager} 0/6] Add fallback variants to PBS API types Stefan Hanreich
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check Stefan Hanreich
2025-11-20 15:04 ` Shannon Sterz
2025-11-20 15:08 ` Stefan Hanreich
[not found] ` <DEGU1341QGIZ.1I1F8IGH8MHE9@proxmox.com>
2025-11-24 9:56 ` Shannon Sterz
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 2/5] proxmox-fixed-string: extract FixedString into own crate Stefan Hanreich
2025-12-01 3:29 ` [pbs-devel] applied: " Thomas Lamprecht
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 3/5] proxmox-fixed-string: implement hash trait Stefan Hanreich
2025-12-01 3:29 ` Thomas Lamprecht [this message]
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 4/5] pve-api-types: add proxmox-fixed-string Stefan Hanreich
2025-12-01 3:29 ` [pbs-devel] applied: " Thomas Lamprecht
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox 5/5] pbs-api-types: add fallback variants to enums in public API Stefan Hanreich
2025-12-01 3:29 ` [pbs-devel] applied: " Thomas Lamprecht
2025-11-20 14:50 ` [pbs-devel] [PATCH proxmox-datacenter-manager 1/1] tree-wide: add enum fallback variants for pbs api types Stefan Hanreich
2025-12-01 2:55 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 2:55 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176455974534.2674830.9440539080891494681.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.