all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] qm cleanup: avoid problematic cleanup during rollback
Date: Sat, 29 Nov 2025 23:49:01 +0100	[thread overview]
Message-ID: <176445653896.1120579.4649668926144963832.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251128125237.117539-1-f.ebner@proxmox.com>

On Fri, 28 Nov 2025 13:52:09 +0100, Fiona Ebner wrote:
> During preparation for rollback, there already is a VM cleanup. The
> rollback operation temporarily drops the file lock for the
> configuration while doing rollback of the volumes on the storage
> layer. If a shutdown operation or more precisely, the cleanup
> thereafter happens concurrently, it can get the file lock and do the
> cleanup (a second time) while rollback is running. If a badly timed
> deactivate for the volume happens, this can cause issues as reported
> in the community forum [0] and confirmed locally (but only managed to
> reproduce with 'saferemove').
> 
> [...]

Applied, thanks!

[1/1] qm cleanup: avoid problematic cleanup during rollback
      commit: ffe8e2dae832641d95fda68aa198e38f60d3e2bd


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-11-29 22:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 12:52 [pve-devel] " Fiona Ebner
2025-11-29 22:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176445653896.1120579.4649668926144963832.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal