[pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition

[pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition

[Hannes Laimer]

We should not submit an empty string when no user is selected, this
trips up the API endpoint.

Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list")
Reported-by: Robert Obkircher <r.obkircher@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/window/TrafficControlEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
index 83b84ff5..7243f5b3 100644
--- a/www/window/TrafficControlEdit.js
+++ b/www/window/TrafficControlEdit.js
@@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
                 name: 'users',
                 multiSelect: true,
                 allowBlank: true,
+                skipEmptyText: true,
                 cbind: {
                     deleteEmpty: '{!isCreate}',
                 },
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition

[Hannes Laimer]

* ui: traffic-control: fix `users` field submission

not sure how `submition` happened :P

On 11/24/25 15:21, Hannes Laimer wrote:
> We should not submit an empty string when no user is selected, this
> trips up the API endpoint.
> 
> Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list")
> Reported-by: Robert Obkircher <r.obkircher@proxmox.com>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   www/window/TrafficControlEdit.js | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
> index 83b84ff5..7243f5b3 100644
> --- a/www/window/TrafficControlEdit.js
> +++ b/www/window/TrafficControlEdit.js
> @@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
>                   name: 'users',
>                   multiSelect: true,
>                   allowBlank: true,
> +                skipEmptyText: true,
>                   cbind: {
>                       deleteEmpty: '{!isCreate}',
>                   },



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition

[Thomas Lamprecht]

On Mon, 24 Nov 2025 15:21:07 +0100, Hannes Laimer wrote:
> We should not submit an empty string when no user is selected, this
> trips up the API endpoint.
> 
> 

Applied, thanks!

[1/1] ui: traffic-control: fix `users` field submition
      commit: 212fad32672bae83b21cb132492c90c88714330c


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel