* [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition
@ 2025-11-24 14:21 Hannes Laimer
2025-11-24 14:27 ` Hannes Laimer
2025-11-24 15:01 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Laimer @ 2025-11-24 14:21 UTC (permalink / raw)
To: pbs-devel
We should not submit an empty string when no user is selected, this
trips up the API endpoint.
Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list")
Reported-by: Robert Obkircher <r.obkircher@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
www/window/TrafficControlEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
index 83b84ff5..7243f5b3 100644
--- a/www/window/TrafficControlEdit.js
+++ b/www/window/TrafficControlEdit.js
@@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
name: 'users',
multiSelect: true,
allowBlank: true,
+ skipEmptyText: true,
cbind: {
deleteEmpty: '{!isCreate}',
},
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition
2025-11-24 14:21 [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition Hannes Laimer
@ 2025-11-24 14:27 ` Hannes Laimer
2025-11-24 15:01 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Laimer @ 2025-11-24 14:27 UTC (permalink / raw)
To: pbs-devel
* ui: traffic-control: fix `users` field submission
not sure how `submition` happened :P
On 11/24/25 15:21, Hannes Laimer wrote:
> We should not submit an empty string when no user is selected, this
> trips up the API endpoint.
>
> Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list")
> Reported-by: Robert Obkircher <r.obkircher@proxmox.com>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/TrafficControlEdit.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
> index 83b84ff5..7243f5b3 100644
> --- a/www/window/TrafficControlEdit.js
> +++ b/www/window/TrafficControlEdit.js
> @@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
> name: 'users',
> multiSelect: true,
> allowBlank: true,
> + skipEmptyText: true,
> cbind: {
> deleteEmpty: '{!isCreate}',
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition
2025-11-24 14:21 [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition Hannes Laimer
2025-11-24 14:27 ` Hannes Laimer
@ 2025-11-24 15:01 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-11-24 15:01 UTC (permalink / raw)
To: pbs-devel, Hannes Laimer
On Mon, 24 Nov 2025 15:21:07 +0100, Hannes Laimer wrote:
> We should not submit an empty string when no user is selected, this
> trips up the API endpoint.
>
>
Applied, thanks!
[1/1] ui: traffic-control: fix `users` field submition
commit: 212fad32672bae83b21cb132492c90c88714330c
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-24 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-24 14:21 [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition Hannes Laimer
2025-11-24 14:27 ` Hannes Laimer
2025-11-24 15:01 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.