From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer 0/2] nic pinning: require first character to be lower-case
Date: Tue, 18 Nov 2025 17:31:08 +0100 [thread overview]
Message-ID: <176348346455.1411996.16895562409267508595.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251118151532.592423-1-s.ivanov@proxmox.com>
On Tue, 18 Nov 2025 16:15:25 +0100, Stoiko Ivanov wrote:
> The regex for validating NICs in pve-common starts with /^[a-z].../
> getting 'name must start with a letter' to a pinned nic-name of 'ABC' is
> confusing. Additionally there was a discrepancy in validating the nic-name
> in the rust-based installers (is_ascii_alphabetic also matches upper-case
> letters, whereas the perl-regex required [a-z])
>
> Align the validation with the version in pve-common.
>
> [...]
Applied, thanks!
[1/2] common: pinning: require first character to be lower-case ascii
commit: 47700a50ab4a8e3322aaa69f6a7ea584519b98e5
[2/2] sys: net: fix error-message for interface names first character
commit: fc9e72091861b0f0981c8a4153c4017839478af7
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-18 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:15 [pve-devel] " Stoiko Ivanov
2025-11-18 15:15 ` [pve-devel] [PATCH installer 1/2] common: pinning: require first character to be lower-case ascii Stoiko Ivanov
2025-11-18 15:15 ` [pve-devel] [PATCH installer 2/2] sys: net: fix error-message for interface names first character Stoiko Ivanov
2025-11-18 16:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176348346455.1411996.16895562409267508595.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.