all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] Revert "fix #6815: ui: resource tree: update tag colors properly"
@ 2025-11-18 13:35 Dominik Csapak
  2025-11-18 14:14 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-11-18 13:35 UTC (permalink / raw)
  To: pve-devel

This reverts commit 952a4f615731c3de0351c94b83bd97340c7e7798.

Since we moved the text rendering to a renderer instead of overwriting
the 'text' property on adding the elements to the tree, this fix is
not necessary anymore since the renderer has the correct information
already.

This also wrongly rendered the guest entries in the tag view with their
'groupRenderer' instead of their normal text (vmid + name).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/tree/ResourceTree.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index b55f124a..097f1cbb 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -611,7 +611,7 @@ Ext.define('PVE.tree.ResourceTree', {
         me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
             me.store.getRootNode().cascadeBy({
                 before: function (node) {
-                    if (node.data.groupbyid || node.data.tags) {
+                    if (node.data.groupbyid) {
                         node.beginEdit();
                         let info = node.data;
                         me.setIconCls(info);
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] Revert "fix #6815: ui: resource tree: update tag colors properly"
  2025-11-18 13:35 [pve-devel] [PATCH manager] Revert "fix #6815: ui: resource tree: update tag colors properly" Dominik Csapak
@ 2025-11-18 14:14 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-18 14:14 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Tue, 18 Nov 2025 14:35:11 +0100, Dominik Csapak wrote:
> This reverts commit 952a4f615731c3de0351c94b83bd97340c7e7798.
> 
> Since we moved the text rendering to a renderer instead of overwriting
> the 'text' property on adding the elements to the tree, this fix is
> not necessary anymore since the renderer has the correct information
> already.
> 
> [...]

Applied, thanks!

[1/1] Revert "fix #6815: ui: resource tree: update tag colors properly"
      commit: 5ad6c6c2f9f47c725b3b10dc394d2c9802ff0e27


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-18 14:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-18 13:35 [pve-devel] [PATCH manager] Revert "fix #6815: ui: resource tree: update tag colors properly" Dominik Csapak
2025-11-18 14:14 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal