all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] oci restore: allow tabs in oci config
Date: Tue, 18 Nov 2025 13:19:22 +0100	[thread overview]
Message-ID: <176346834725.1131716.8350782108149660029.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251118110258.103565-1-s.sterz@proxmox.com>

On Tue, 18 Nov 2025 12:02:58 +0100, Shannon Sterz wrote:
> it is fairly common to use tabs in oci configs. for example, the php
> oci image from docker uses them quite extensively [1]. so exclude them
> from the control characters we check for.
> 
> [1]:
> https://github.com/docker-library/php/blob/8e01ffe94ed4ccca7c0a37be6dcb45995cf5d93b/8.3/trixie/apache/Dockerfile#L20
> 
> [...]

Applied, thanks!
I also adapted the config schema for env an entrypoint in a follow-up to allow
tabs in the values there too.

[1/1] oci restore: allow tabs in oci config
      commit: f7b2a27ef94c0b382d35c9e03ed64884b8460017


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-11-18 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 11:02 [pve-devel] " Shannon Sterz
2025-11-18 12:19 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176346834725.1131716.8350782108149660029.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal