[pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension

[pve-devel] [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension

[Fiona Ebner]

While archives with unknown or undetermined subtype could be shown,
this is only for autocompletion, so users can still specify those
manually if required.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7815b608..fe23d4b9 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -8592,7 +8592,7 @@ sub complete_backup_archives {
     my $res = [];
     foreach my $id (keys %$data) {
 	foreach my $item (@{$data->{$id}}) {
-	    next if $item->{format} !~ m/^vma\.(${\PVE::Storage::Plugin::COMPRESSOR_RE})$/;
+	    next if ($item->{subtype} // '') ne 'qemu';
 	    push @$res, $item->{volid} if defined($item->{volid});
 	}
     }
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore

[Fiona Ebner]

While archives with unknown or undetermined subtype could be shown,
this is only for autocompletion, so users can still specify those
manually if required.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 65d0fa8..e154efe 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2341,6 +2341,7 @@ sub complete_os_templates {
     my $res = [];
     foreach my $id (keys %$data) {
 	foreach my $item (@{$data->{$id}}) {
+	    next if $vtype eq 'backup' && ($item->{subtype} // '') ne 'lxc';
 	    push @$res, $item->{volid} if defined($item->{volid});
 	}
     }
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore

[Fiona Ebner]

Am 14.06.24 um 13:29 schrieb Fiona Ebner:
> While archives with unknown or undetermined subtype could be shown,
> this is only for autocompletion, so users can still specify those
> manually if required.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/LXC.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 65d0fa8..e154efe 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -2341,6 +2341,7 @@ sub complete_os_templates {
>      my $res = [];
>      foreach my $id (keys %$data) {
>  	foreach my $item (@{$data->{$id}}) {
> +	    next if $vtype eq 'backup' && ($item->{subtype} // '') ne 'lxc';
>  	    push @$res, $item->{volid} if defined($item->{volid});
>  	}
>      }

Ping regarding this one, still applies cleanly.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container] autocomplete: os templates: do not list VM backup archives for restore

[Thomas Lamprecht]

On Fri, 14 Jun 2024 13:29:47 +0200, Fiona Ebner wrote:
> While archives with unknown or undetermined subtype could be shown,
> this is only for autocompletion, so users can still specify those
> manually if required.
> 
> 

Applied, with trivial conflict from perltidy fixed up, thanks!

[1/1] autocomplete: os templates: do not list VM backup archives for restore
      commit: e6596e0bd04fcf388b88ee69837c8749875f7763


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension

[Thomas Lamprecht]

Am 14/06/2024 um 13:29 schrieb Fiona Ebner:
> While archives with unknown or undetermined subtype could be shown,
> this is only for autocompletion, so users can still specify those
> manually if required.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel