From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH ha-manager 1/1] api: resources: fix uninitialized value in check_service_state
Date: Mon, 17 Nov 2025 22:37:50 +0100 [thread overview]
Message-ID: <176341546191.4190222.7116070180214866093.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251110143627.365434-2-d.kral@proxmox.com>
On Mon, 10 Nov 2025 15:36:16 +0100, Daniel Kral wrote:
> check_service_state(...) calls get_service_status(...), which assumes
> that a configured HA resource is already present in the manager status.
>
> If a HA resource is added to the configuration file and interacted with
> such that check_service_state(...) is called before the HA Manager loads
> the new HA resource in its state, then $service_status->{state} will be
> undefined.
>
> [...]
Applied, thanks!
[1/1] api: resources: fix uninitialized value in check_service_state
commit: e4ebb699716b9653be25446e6a72c7ebc720773a
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 14:36 [pve-devel] [PATCH container/ha-manager/qemu-server 0/5] Small HA-on-create improvements Daniel Kral
2025-11-10 14:36 ` [pve-devel] [PATCH ha-manager 1/1] api: resources: fix uninitialized value in check_service_state Daniel Kral
2025-11-17 21:37 ` Thomas Lamprecht [this message]
2025-11-10 14:36 ` [pve-devel] [PATCH qemu-server 1/3] api: create_vm: use ha-manager command to add VM as an HA resource Daniel Kral
2025-11-17 21:27 ` Thomas Lamprecht
2025-11-10 14:36 ` [pve-devel] [PATCH qemu-server 2/3] qmrestore: allow starting a VM after it was restored successfully Daniel Kral
2025-11-17 21:27 ` Thomas Lamprecht
2025-11-10 14:36 ` [pve-devel] [PATCH qemu-server 3/3] qmrestore: allow adding a VM as an HA resource after it was restored Daniel Kral
2025-11-17 21:27 ` Thomas Lamprecht
2025-11-10 14:36 ` [pve-devel] [PATCH container 1/1] api: create_vm: use ha-manager command to add container as an HA resource Daniel Kral
2025-11-17 21:27 ` [pve-devel] applied: " Thomas Lamprecht
2025-11-17 16:11 ` [pve-devel] [PATCH container/ha-manager/qemu-server 0/5] Small HA-on-create improvements Michael Köppl
2025-11-17 16:24 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176341546191.4190222.7116070180214866093.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.