From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-firewall 0/2] Fix generating rules with both ICMP type and code set
Date: Mon, 17 Nov 2025 16:43:03 +0100 [thread overview]
Message-ID: <176339417955.3750683.12238509117638101753.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251008131457.178090-1-s.hanreich@proxmox.com>
On Wed, 08 Oct 2025 15:14:52 +0200, Stefan Hanreich wrote:
> If both type and code were set for rules with Protocol ICMP(v6) then
> proxmox-firewall would only generate the statement matching on the code, but not
> on the type.
>
> proxmox-firewall:
>
> Stefan Hanreich (2):
> firewall: fix generating rules with both type and code set
> firewall: regenerate snapshot for tests
>
> [...]
Applied, thanks!
[1/2] firewall: fix generating rules with both type and code set
commit: b6c1be33139fc94a4a3b61b8ffef10f854ce3b50
[2/2] firewall: regenerate snapshot for tests
commit: 2699408ce2cb95a08b11eb754778493c2c6bd62b
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 13:14 [pve-devel] " Stefan Hanreich
2025-10-08 13:14 ` [pve-devel] [PATCH proxmox-firewall 1/2] firewall: fix generating rules with both " Stefan Hanreich
2025-10-08 13:14 ` [pve-devel] [PATCH proxmox-firewall 2/2] firewall: regenerate snapshot for tests Stefan Hanreich
2025-11-17 15:43 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176339417955.3750683.12238509117638101753.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.