[pve-devel] [PATCH network] api: sdn: show full device name of firewall bridge ports

[pve-devel] [PATCH network] api: sdn: show full device name of firewall bridge ports

[Gabriel Goller]

The bridges endpoint also returns the firewall ports of the bridges.
From the firewall port interface we extract the vmid and the vm network
device index. Instead of just showing a number, return the whole
`net{index}` name. This makes it easier to understand as the vm
configuration also shows `net{index}` as the key of the interfaces.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/API2/Network/SDN/Nodes/Zone.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Network/SDN/Nodes/Zone.pm b/src/PVE/API2/Network/SDN/Nodes/Zone.pm
index 43acbe9c203f..f86ad1ead271 100644
--- a/src/PVE/API2/Network/SDN/Nodes/Zone.pm
+++ b/src/PVE/API2/Network/SDN/Nodes/Zone.pm
@@ -180,7 +180,7 @@ __PACKAGE__->register_method({
                             index => {
                                 description =>
                                     'The index of the guests network device that this interface belongs to.',
-                                type => 'number',
+                                type => 'string',
                                 optional => 1,
                             },
                             primary_vlan => {
@@ -271,7 +271,7 @@ __PACKAGE__->register_method({
 
                 if ($ifname =~ m/^(?:fwpr(\d+)p(\d+)|veth(\d+)i(\d+)|tap(\d+)i(\d+))$/) {
                     $port->{vmid} = $1;
-                    $port->{index} = $2;
+                    $port->{index} = "net$2";
                 }
 
                 if ($result->{$master}->{vlan_filtering} == 1) {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH network] api: sdn: show full device name of firewall bridge ports

[Gabriel Goller]

Forgot the:

Reported-by: Friedrich Weber <f.weber@proxmox.com>

:)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH network] api: sdn: show full device name of firewall bridge ports

[Thomas Lamprecht]

On Mon, 17 Nov 2025 15:01:07 +0100, Gabriel Goller wrote:
> The bridges endpoint also returns the firewall ports of the bridges.
> >From the firewall port interface we extract the vmid and the vm network
> device index. Instead of just showing a number, return the whole
> `net{index}` name. This makes it easier to understand as the vm
> configuration also shows `net{index}` as the key of the interfaces.
> 
> 
> [...]

Applied, thanks!

[1/1] api: sdn: show full device name of firewall bridge ports
      commit: 3280f4bd645cdb73e616ee77471a470083dd0e6f


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel