From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Filip Schauer <f.schauer@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] config: allow empty environment variables
Date: Mon, 17 Nov 2025 15:15:45 +0100 [thread overview]
Message-ID: <176338894275.3640252.15864259508521949438.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251117124935.126982-1-f.schauer@proxmox.com>
On Mon, 17 Nov 2025 13:49:03 +0100, Filip Schauer wrote:
> This fixes a problem with the docker.io/httpd OCI image which specifies
> an empty environment variable. This violated the pattern of the `env`
> property, causing `pct config <vmid>` to fail with:
> ```
> env: value does not match the regex pattern
> ```
>
> [...]
I actually wondered about that and had the frontend "allowBlank" check
initially such that the value was only required if the name field was set (as
the variable simply gets deleted otherwise), but I then changed it to both to
be required, as allowing something more is almost always easier to do in the
future compared to restricting it, especially if it involves API exposed schema.
Anyhow, the UI part would need now also adaption to make your change fully work
also there.
Applied, thanks!
[1/1] config: allow empty environment variables
commit: 9a5f5ce5cfdbc85b2d40a4a20662065d18b85f6c
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 12:49 [pve-devel] " Filip Schauer
2025-11-17 13:59 ` Fabian Grünbichler
2025-11-17 14:05 ` Fabian Grünbichler
2025-11-17 14:08 ` Filip Schauer
2025-11-17 14:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176338894275.3640252.15864259508521949438.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.