* [pve-devel] [PATCH storage] disks: add a guard possible nonexistent field
@ 2025-10-24 12:13 Maximiliano Sandoval
2025-11-13 23:19 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2025-10-24 12:13 UTC (permalink / raw)
To: pve-devel
When running
pveceph osd create <device>
one would get one or two warnings:
Use of uninitialized value in pattern match (m//) at /usr/share/perl5/PVE/Diskmanage.pm line 317.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/PVE/Diskmanage.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Diskmanage.pm b/src/PVE/Diskmanage.pm
index 1062bfdf..d1cf24da 100644
--- a/src/PVE/Diskmanage.pm
+++ b/src/PVE/Diskmanage.pm
@@ -316,6 +316,7 @@ sub get_ceph_volume_infos {
# $result autovivification is wanted, to not creating empty hashes
if (
($type eq 'block' || $type eq 'data')
+ && $fields->[2]
&& $fields->[2] =~ m/ceph.osd_id=([^,]+)/
) {
$result->{$dev}->{osdid} = $1;
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH storage] disks: add a guard possible nonexistent field
2025-10-24 12:13 [pve-devel] [PATCH storage] disks: add a guard possible nonexistent field Maximiliano Sandoval
@ 2025-11-13 23:19 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-11-13 23:19 UTC (permalink / raw)
To: pve-devel, Maximiliano Sandoval
On Fri, 24 Oct 2025 14:13:09 +0200, Maximiliano Sandoval wrote:
> When running
>
> pveceph osd create <device>
>
> one would get one or two warnings:
>
> Use of uninitialized value in pattern match (m//) at /usr/share/perl5/PVE/Diskmanage.pm line 317.
>
> [...]
Applied, thanks!
[1/1] disks: add a guard possible nonexistent field
commit: 5b949979f7179b1135dead8b4a8af5b5057accff
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-13 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-24 12:13 [pve-devel] [PATCH storage] disks: add a guard possible nonexistent field Maximiliano Sandoval
2025-11-13 23:19 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.