From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox_login_manager v2 0/4] fix #6983: ui: make cosmetic changes inside the login screen
Date: Wed, 12 Nov 2025 10:21:47 +0100 [thread overview]
Message-ID: <176293927548.1084579.14895903364084970316.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251111140005.41510-1-s.shaji@proxmox.com>
On Tue, 11 Nov 2025 15:00:01 +0100, Shan Shaji wrote:
> This patch series fixes the issues recieved as feedback after testing
> the IOS Test Flight build.
>
> - when adding a remote the continue button is initially submit-able, even
> though the "Origin" field is empty. taping continue will shop an error message and
> gray out the button. Fixed the issue by disabling the button by default.
> - In portrait mode the margins around the "Origin" field are bit tight.
> Fixed the issue by adding more padding around the form.
> - In landscape mode when adding a remote once the "Origin" field is
> selected, the top bar becomes a slightly different shade of blue. Fixed
> the issue by removing the app bar and stacked the close button.
>
> [...]
Applied, thanks!
[1/4] fix: ui: disable continue button by default in login form
commit: 58cd68891968431827a4969bdd25c35233b03e8f
[2/4] fix: ui: add more padding around the form in portrait mode
commit: 7a9682a0e4fbefab61a8b660e7793aea1fcc24ae
[3/4] fix: ui: remove app bar and stack the close button on body
commit: 3708583d3d3ff1af46fb32dfff9708c3d3a5d6ec
[4/4] cleanup: run dart format command to fix formatting
commit: 7751b4376b62c088e5d3089e7b7fb60a9c0c49fd
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-12 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 14:00 [pve-devel] " Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 1/4] fix: ui: disable continue button by default in login form Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 2/4] fix: ui: add more padding around the form in portrait mode Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 3/4] fix: ui: remove app bar and stack the close button on body Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 4/4] cleanup: run dart format command to fix formatting Shan Shaji
2025-11-12 9:21 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176293927548.1084579.14895903364084970316.b4-ty@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.