From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/2] fix 2 issues with s3 store verifies
Date: Tue, 11 Nov 2025 14:57:05 +0100 [thread overview]
Message-ID: <1762869260.4x95zysxo6.astroid@yuna.none> (raw)
In-Reply-To: <20251029110625.375975-1-c.ebner@proxmox.com>
although that nested match there would benefit from some refactoring,
and I am also not 100% sure we shouldn't add some additional checks to
the flow there (e.g., heal the S3 chunk if the local one is correct,
verify the local one is correct in addition to the S3 one, ensure
renaming happens even if either side is missing the "corrupt" chunk?)
On October 29, 2025 12:06 pm, Christian Ebner wrote:
> This patches were pulled out from the original patch series [0] since
> they are independent from the bigger series attempting to fix the
> possible race between corrupt chunk renaming and chunk insert/upload
> and better reviewed/tested independently.
>
> Patch 1 makes sure the mutex guard to sync up access to the corrupt
> chunk list is dropped before attempting to rename a corrupt chunk,
> which will call into async context on s3 stores. Otherwise deadlock
> can arise.
>
> Patch 2 is a followup to the bugfix for issue #6665, which however
> did not correctly distinguish between transient fetching errors and
> the possible chunk DataBlob decoding error from the response body in
> case of a successful response.
>
> [0] https://lore.proxmox.com/pbs-devel/20251016131819.349049-6-c.ebner@proxmox.com/T/
>
> Christian Ebner (2):
> verify: never hold mutex lock in async scope on corrupt chunk rename
> verify: distinguish s3 object fetching and chunk loading error
>
> src/backup/verify.rs | 34 +++++++++++++++++++---------------
> 1 file changed, 19 insertions(+), 15 deletions(-)
>
> --
> 2.47.3
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-11 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 11:06 [pbs-devel] " Christian Ebner
2025-10-29 11:06 ` [pbs-devel] [PATCH proxmox-backup 1/2] verify: never hold mutex lock in async scope on corrupt chunk rename Christian Ebner
2025-10-29 11:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] verify: distinguish s3 object fetching and chunk loading error Christian Ebner
2025-11-11 13:57 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1762869260.4x95zysxo6.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.