From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] partially-applied: [PATCH proxmox-backup v2 0/3] fix GC atime update race window
Date: Fri, 7 Nov 2025 16:45:56 +0100 [thread overview]
Message-ID: <176253035292.3494069.12188877610255234903.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251106171358.865503-1-c.ebner@proxmox.com>
On Thu, 06 Nov 2025 18:13:55 +0100, Christian Ebner wrote:
> Sweeping of unused chunks during garbage collection checks their
> atime to distinguish between chunks being in-use and chunks no
> longer being used. While garbage collection does lock the chunk
> store by guarding its mutex before reading file stats and deleting
> unused chunks, the conditional touch did not do this before updating
> the chunks atime (thereby also checking the presence).
>
> [...]
Applied the first two patches, thanks!
For the third one I would rather like an actual review from Fabian, especially
w.r.t. adding the callback.
[1/3] chunk store: limit scope for atime update helper methods
commit: 5799bcda53220c78ff45a44e5b58582a0fac2e83
[2/3] chunk store: fix race window between chunk stat and gc cleanup
commit: d45077366778c20293901b5e3ef36725cf123f88
[3/3] datastore: insert chunk marker and touch bad chunks in locked context
SKIPPED
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-07 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 17:13 [pbs-devel] " Christian Ebner
2025-11-06 17:13 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] chunk store: limit scope for atime update helper methods Christian Ebner
2025-11-06 17:13 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] chunk store: fix race window between chunk stat and gc cleanup Christian Ebner
2025-11-06 17:13 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] datastore: insert chunk marker and touch bad chunks in locked context Christian Ebner
2025-11-07 15:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176253035292.3494069.12188877610255234903.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.