[yew-devel] [PATCH yew-comp v2 0/2] token panel follow up

[yew-devel] [PATCH yew-comp v2 0/2] token panel follow up

[Shannon Sterz]

these two patches add a confirmation dialog to the remove token dialog
and also slightly rephrase the wording in the confirmation dialogs in
general for clarity.

Changelog
---------

changes since v1:

- add a patch that clarifies the confim messages (thanks @ Maximiliano
  Sandoval)

Shannon Sterz (2):
  token panel: ask for confirmation when removing a token
  token panel: rephrase "usage sites" to "user of the token" for clarity

 src/token_panel.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

--
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] [PATCH yew-comp v2 1/2] token panel: ask for confirmation when removing a token

[Shannon Sterz]

by using a `ConfirmButton` instead of just a `Button`.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/token_panel.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/token_panel.rs b/src/token_panel.rs
index 55795a6..d61063a 100644
--- a/src/token_panel.rs
+++ b/src/token_panel.rs
@@ -190,7 +190,9 @@ impl LoadableComponent for ProxmoxTokenView {
                     .on_activate(link.change_view_callback(|_| Some(ViewState::EditToken))),
             )
             .with_child(
-                Button::new(tr!("Remove"))
+                ConfirmButton::new(tr!("Remove"))
+                    .confirm_message(tr!("Are you sure you want to remove the API token? \
+                        All current usage sites will lose access!"))
                     .disabled(disabled)
                     .on_activate(link.callback(|_| Msg::Remove)),
             )
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] [PATCH yew-comp v2 2/2] token panel: rephrase "usage sites" to "user of the token" for clarity

[Shannon Sterz]

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/token_panel.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/token_panel.rs b/src/token_panel.rs
index d61063a..e0ca767 100644
--- a/src/token_panel.rs
+++ b/src/token_panel.rs
@@ -192,7 +192,7 @@ impl LoadableComponent for ProxmoxTokenView {
             .with_child(
                 ConfirmButton::new(tr!("Remove"))
                     .confirm_message(tr!("Are you sure you want to remove the API token? \
-                        All current usage sites will lose access!"))
+                        All existing users of the token will lose access!"))
                     .disabled(disabled)
                     .on_activate(link.callback(|_| Msg::Remove)),
             )
@@ -201,7 +201,7 @@ impl LoadableComponent for ProxmoxTokenView {
                 ConfirmButton::new(tr!("Regenerate Secret"))
                     .confirm_message(tr!(
                         "Do you want to regenerate the secret of the selected API token? \
-                        All current usage sites will lose access!"
+                        All existing users of the token will lose access!"
                     ))
                     .disabled(disabled)
                     .on_activate(link.callback(|_| Msg::Regenerate)),
-- 
2.47.3



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH yew-comp v2 0/2] token panel follow up

[Thomas Lamprecht]

On Thu, 23 Oct 2025 16:44:23 +0200, Shannon Sterz wrote:
> these two patches add a confirmation dialog to the remove token dialog
> and also slightly rephrase the wording in the confirmation dialogs in
> general for clarity.
> 
> Changelog
> ---------
> 
> [...]

Applied, thanks!

[1/2] token panel: ask for confirmation when removing a token
      commit: ef1a3dfa6f2d40ba6932ac7c349b32c50f5b6c54
[2/2] token panel: rephrase "usage sites" to "user of the token" for clarity
      commit: 98aa5f50d29cb66bbd4d53982aeb460f02cef636


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel