[pve-devel] [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks

[pve-devel] [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks

[Markus Ebner via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 3957 bytes --]

From: Markus Ebner <info@ebner-markus.de>
To: pve-devel@lists.proxmox.com
Cc: Markus Ebner <info@ebner-markus.de>
Subject: [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks
Date: Mon,  3 Nov 2025 12:38:21 +0100
Message-ID: <20251103113900.140922-2-info@ebner-markus.de>

The nocloud ISO image disk format mandates 4 files in the root folder
called "network-config", "user-data", "meta-data" and "vendor-data".
These filenames are not ISO9660 Level 3 compatible.

To circumvent this, Proxmox - to date - generates nocloud cloud-init
ISOs with the Rockridge extension (-R) - which adds support for POSIX
compatible filenames and metadata. But the Rockridge extension is not
supported by Windows. In order to also support these filenames for
Windows, also add the joliet extension to generated ISO disks.

Signed-off-by: Markus Ebner <info@ebner-markus.de>
---
 src/PVE/QemuServer/Cloudinit.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/Cloudinit.pm b/src/PVE/QemuServer/Cloudinit.pm
index 349cf90b..7d62f5ab 100644
--- a/src/PVE/QemuServer/Cloudinit.pm
+++ b/src/PVE/QemuServer/Cloudinit.pm
@@ -53,7 +53,7 @@ sub commit_cloudinit_disk {
     print "generating cloud-init ISO\n";
     eval {
         run_command([
-            ['genisoimage', '-quiet', '-iso-level', '3', '-R', '-V', $label, $path],
+            ['genisoimage', '-quiet', '-iso-level', '3', '-J', '-R', '-V', $label, $path],
             [
                 'qemu-img',
                 'dd',
-- 
2.51.1



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks

[Mira Limbeck]

Thank you for the patch!

The repository is wrong, it should be qemu-server not container.


I couldn't get a Windows Server 2022 to work with NoCloud to test it
directly.
But it continued to work with the default (citype: configdrive2) even
after the patch.
And a Ubuntu 25.10 cloud image also worked with its default (citype:
nocloud).

I also verified that Windows sees the files with the correct name after
this patch.

So the patch looks good to me.

Consider this:
Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container 1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks

[Thomas Lamprecht]

On Mon, 03 Nov 2025 12:38:21 +0100, Markus Ebner via pve-devel wrote:
> The nocloud ISO image disk format mandates 4 files in the root folder
> called "network-config", "user-data", "meta-data" and "vendor-data".
> These filenames are not ISO9660 Level 3 compatible.
> 
> To circumvent this, Proxmox - to date - generates nocloud cloud-init
> ISOs with the Rockridge extension (-R) - which adds support for POSIX
> compatible filenames and metadata. But the Rockridge extension is not
> supported by Windows. In order to also support these filenames for
> Windows, also add the joliet extension to generated ISO disks.
> 
> [...]

Applied, thanks!

[1/1] Fix #6989: cloudinit: Enable joliet ISO extension for config disks
      commit: 03f2fbafc2b67819e089dbed809aca174edb2309


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel