[pve-devel] [PATCH manager 0/2] improve UX in resource edit dialog

[pve-devel] [PATCH manager 0/2] improve UX in resource edit dialog

[Michael Köppl]

The first patch fixes an annoyance with the resource edit dialog where
the dropdown text field would automatically be focused upon opening the
dialog and would hide the dialog behind the dropdown. To avoid this, the
defaultFocus is turned off.

The second patch also changes this input field to not allow blank
inputs, giving users better visual feedback.

pve-manager:

Michael Köppl (2):
  ui: ha: remove focus from VM/CT dropdown in resource edit window
  ui: ha: do not allow an empty VM/CT dropdown in resource edit window

 www/manager6/ha/ResourceEdit.js | 2 ++
 1 file changed, 2 insertions(+)


Summary over all repositories:
  1 files changed, 2 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.8.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/2] ui: ha: remove focus from VM/CT dropdown in resource edit window

[Michael Köppl]

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/ha/ResourceEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
index 428672a82..18ed166ad 100644
--- a/www/manager6/ha/ResourceEdit.js
+++ b/www/manager6/ha/ResourceEdit.js
@@ -165,6 +165,7 @@ Ext.define('PVE.ha.VMResourceEdit', {
     vmid: undefined,
     guestType: undefined,
     isCreate: undefined,
+    defaultFocus: undefined,
 
     initComponent: function () {
         var me = this;
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] ui: ha: do not allow an empty VM/CT dropdown in resource edit window

[Michael Köppl]

This does not only improve visual feedback to the user in the form of
red highlighting, but also disables the "Add" button while the field is
still empty.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/ha/ResourceEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
index 18ed166ad..a4f53dad4 100644
--- a/www/manager6/ha/ResourceEdit.js
+++ b/www/manager6/ha/ResourceEdit.js
@@ -86,6 +86,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
                 fieldLabel: me.vmid && me.guestType === 'ct' ? 'CT' : 'VM',
                 value: me.vmid,
                 store: vmidStore,
+                allowBlank: false,
                 validateExists: true,
             },
             {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 0/2] improve UX in resource edit dialog

[Thomas Lamprecht]

On Fri, 19 Sep 2025 17:33:15 +0200, Michael Köppl wrote:
> The first patch fixes an annoyance with the resource edit dialog where
> the dropdown text field would automatically be focused upon opening the
> dialog and would hide the dialog behind the dropdown. To avoid this, the
> defaultFocus is turned off.
> 
> The second patch also changes this input field to not allow blank
> inputs, giving users better visual feedback.
> 
> [...]

Applied, thanks!

[1/2] ui: ha: remove focus from VM/CT dropdown in resource edit window
      commit: 94412c6b535ca729af8fca97528d370a86eacae6
[2/2] ui: ha: do not allow an empty VM/CT dropdown in resource edit window
      commit: 2e39de34a54562f71e2885ac4002e3931ee74b55


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel