[pdm-devel] [PATCH datacenter-manager 0/1] buildsys: initialize pwt-assets as submodule automatically

[pdm-devel] [PATCH datacenter-manager 0/1] buildsys: initialize pwt-assets as submodule automatically

[Fiona Ebner]

When the submodule is not initialized there would be some errors at
the beginning of the build like:
> Error: Can't find stylesheet to import.
but then cargo would continue and compile everything only for the
build to fail at the very end.

proxmox-datacenter-manager:

Fiona Ebner (1):
  buildsys: initialize pwt-assets as submodule automatically

 ui/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


Summary over all repositories:
  1 files changed, 4 insertions(+), 1 deletions(-)

-- 
Generated by git-murpp 0.5.0


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 1/1] buildsys: initialize pwt-assets as submodule automatically

[Fiona Ebner]

When the submodule is not initialized there would be some errors at
the beginning of the build like:
> Error: Can't find stylesheet to import.
but then cargo would continue and compile everything only for the
build to fail at the very end.

Copied from Stoiko's equivalent patch for PMG [0].

[0]: https://lore.proxmox.com/pmg-devel/20251028163628.79739-2-s.ivanov@proxmox.com/

Co-developed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

By chance, I stumbled upon Stoiko's patch for PMG after running into
the issue myself in PDM :)

 ui/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ui/Makefile b/ui/Makefile
index 61e5c77..49ae8ee 100644
--- a/ui/Makefile
+++ b/ui/Makefile
@@ -75,8 +75,11 @@ install: $(COMPILED_OUTPUT) index.hbs
 	install -m0644 dist/material-yew-style.css $(DESTDIR)$(UIDIR)
 	install -m0644 dist/desktop-yew-style.css $(DESTDIR)$(UIDIR)
 
+.PHONY: submodule
+submodule:
+	test -f "pwt-assets/README.md" || git submodule update --init
 
-$(BUILDDIR):
+$(BUILDDIR): submodule
 	rm -rf $@ $@.tmp
 	mkdir -p $@.tmp/ui
 	cp -a debian/ src/ pwt-assets/ images/ css/ index.hbs Makefile Cargo.toml $@.tmp/ui
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager 1/1] buildsys: initialize pwt-assets as submodule automatically

[Thomas Lamprecht]

On Wed, 29 Oct 2025 15:14:03 +0100, Fiona Ebner wrote:
> When the submodule is not initialized there would be some errors at
> the beginning of the build like:
> > Error: Can't find stylesheet to import.
> but then cargo would continue and compile everything only for the
> build to fail at the very end.
> 
> Copied from Stoiko's equivalent patch for PMG [0].
> 
> [...]

Applied, thanks!

[1/1] buildsys: initialize pwt-assets as submodule automatically
      commit: fe0f27302304ff8069d46c86865fe1158746ef4d


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel