* [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text
@ 2025-09-16 12:57 Michael Köppl
2025-09-30 16:07 ` Michael Köppl
2025-10-02 7:58 ` [pve-devel] applied: " Fiona Ebner
0 siblings, 2 replies; 3+ messages in thread
From: Michael Köppl @ 2025-09-16 12:57 UTC (permalink / raw)
To: pve-devel
Without this change, only the value of the type variable would be used
as the task description for task types without an entry in the
task_desc_table.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Utils.js b/src/Utils.js
index a0c6ca5..236390a 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -770,7 +770,7 @@ Ext.define('Proxmox.Utils', {
if (!farray) {
text = type;
if (id) {
- type += ' ' + id;
+ text += ' ' + id;
}
return text;
} else if (Ext.isFunction(farray)) {
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text
2025-09-16 12:57 [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text Michael Köppl
@ 2025-09-30 16:07 ` Michael Köppl
2025-10-02 7:58 ` [pve-devel] applied: " Fiona Ebner
1 sibling, 0 replies; 3+ messages in thread
From: Michael Köppl @ 2025-09-30 16:07 UTC (permalink / raw)
To: pve-devel
ping, still applies
On 9/16/25 2:57 PM, Michael Köppl wrote:
> Without this change, only the value of the type variable would be used
> as the task description for task types without an entry in the
> task_desc_table.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> src/Utils.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Utils.js b/src/Utils.js
> index a0c6ca5..236390a 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -770,7 +770,7 @@ Ext.define('Proxmox.Utils', {
> if (!farray) {
> text = type;
> if (id) {
> - type += ' ' + id;
> + text += ' ' + id;
> }
> return text;
> } else if (Ext.isFunction(farray)) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text
2025-09-16 12:57 [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text Michael Köppl
2025-09-30 16:07 ` Michael Köppl
@ 2025-10-02 7:58 ` Fiona Ebner
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2025-10-02 7:58 UTC (permalink / raw)
To: pve-devel, Michael Köppl
On Tue, 16 Sep 2025 14:57:46 +0200, Michael Köppl wrote:
> Without this change, only the value of the type variable would be used
> as the task description for task types without an entry in the
> task_desc_table.
Applied, thanks!
[1/1] fix: utils: correctly append id to task description text
commit: e68345f514250cf67fd6bf4aa196d7bda0133bb6
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-02 7:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-16 12:57 [pve-devel] [PATCH widget-toolkit 1/1] fix: utils: correctly append id to task description text Michael Köppl
2025-09-30 16:07 ` Michael Köppl
2025-10-02 7:58 ` [pve-devel] applied: " Fiona Ebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.