From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] JSONSchema: property strings: handle boolean default_key consistently
Date: Tue, 30 Sep 2025 19:36:10 +0200 [thread overview]
Message-ID: <175925376551.516906.13322499800692827428.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250912093919.1715010-1-d.csapak@proxmox.com>
On Fri, 12 Sep 2025 11:39:09 +0200, Dominik Csapak wrote:
> A schema with a default_key that is of type boolean, e.g.
>
> ```
> enabled => {
> type => 'boolean',
> default_key = 1,
> },
> ```
> (can be found for example in qemu-server's 'agent' property)
>
> [...]
Applied, with the commit message reworked as I found it a bit hard to follow
the examples that way, thanks!
I also added some basic test system in a follow-up commit, for now it really
focuses on this issue here, but should be relatively easy to expand to cover
more code area of property string but also rest of JSON schema.
[1/1] JSONSchema: property strings: handle boolean default_key consistently
commit: ac547b8739dc8e40bc05b14e4431298104a6e0e2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-30 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 9:39 [pve-devel] " Dominik Csapak
2025-09-30 17:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175925376551.516906.13322499800692827428.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.