From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 1/4] ui: pve: storage: clippy fix
Date: Fri, 26 Sep 2025 12:47:57 +0200 [thread overview]
Message-ID: <175888367274.3582401.2741606156308428063.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250926072017.558000-1-d.csapak@proxmox.com>
On Fri, 26 Sep 2025 09:20:05 +0200, Dominik Csapak wrote:
> unnecessary reference, after we remove that, it's an unnecessary closure
>
>
Applied, thanks!
I reworded the commit message though, as especially the one from patch 3/4 was
misleading (fixes status update not rrd update). Also made a follow-up to
change the name of the timeout update reference guards to not start with an
underscore, as then we would have noticed this earlier.
We should avoud rework other code sides using this problematic pattern too, not
sure if the "_guard" prefix is the best one ("_holder" might be an
alternative), but it's semantically true enough and we can change that still.
[1/4] ui: pve: storage: clippy fix
commit: cf90529e6d250dd4113db3884efc8ce46c02699c
[2/4] ui: pve: storage: remove unnecessary import
commit: f8c9d3db5cd51dfff92384379f764a0710c29ab7
[3/4] ui: pve: storage: fix rrd update
commit: c515d324ba077625b0f15ccf08c878bc97fdb12e
[4/4] ui: pve: storage: remove unnecessary 'enabled' status line
commit: e8be46072ead4e53dd3cec04bc26ed90642dcffd
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-09-26 10:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 7:20 Dominik Csapak
2025-09-26 7:20 ` [pdm-devel] [PATCH datacenter-manager 2/4] ui: pve: storage: remove unnecessary import Dominik Csapak
2025-09-26 7:20 ` [pdm-devel] [PATCH datacenter-manager 3/4] ui: pve: storage: fix rrd update Dominik Csapak
2025-09-26 7:20 ` [pdm-devel] [PATCH datacenter-manager 4/4] ui: pve: storage: remove unnecessary 'enabled' status line Dominik Csapak
2025-09-26 10:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175888367274.3582401.2741606156308428063.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.