From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pmg-devel] applied: [PATCH pmg-yew-quarantine-gui 1/1] spam list: add option menu
Date: Tue, 23 Sep 2025 16:46:20 +0200 [thread overview]
Message-ID: <175863877658.15332.15165882439490865681.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250923132013.3145698-3-d.csapak@proxmox.com>
On Tue, 23 Sep 2025 15:20:08 +0200, Dominik Csapak wrote:
> this contains options to
> * change the language
> * switch to the desktop view (by appending mobile=0 to the url)
> * logout
>
>
Applied, thanks!
One thing to improve would be to navigate to the spam quarantine list in the
ExtJS UI if the route in the hash is empty, as otherwise one sees a blank panel
when clicking the link here. While we could also set the hash to
'#pmgSpamQuarantine' here in the Yew UI, IMO it would be a slightly better fit
to adapt the ExtJS one, to avoid coupling between them.
[1/1] spam list: add option menu
commit: c5ce8a49c8f266df103b44dd255345fbda0fa499
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-09-23 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 13:20 [pmg-devel] [PATCH pmg-gui/pmg-yew-quarantine-gui 0/2] quarantine: allow switching between mobile and desktop ui Dominik Csapak
2025-09-23 13:20 ` [pmg-devel] [PATCH pmg-gui 1/1] quarantine view: add option to switch to mobile view Dominik Csapak
2025-09-23 15:21 ` Thomas Lamprecht
2025-09-23 13:20 ` [pmg-devel] [PATCH pmg-yew-quarantine-gui 1/1] spam list: add option menu Dominik Csapak
2025-09-23 14:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175863877658.15332.15165882439490865681.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.