From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v2 0/3] feat: ui: add bottom sheet to show editable options of VMs/CTs
Date: Tue, 23 Sep 2025 14:57:34 +0200 [thread overview]
Message-ID: <175863221771.3361632.13959607348963688505.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250923122334.301053-1-s.shaji@proxmox.com>
On Tue, 23 Sep 2025 14:23:31 +0200, Shan Shaji wrote:
> On the options page for VMs and CTs it was easy to change the
> configs by mistake. To avoid that, all currently available
> editable options will be shown inside a bottom sheet.
>
> changes since v1: Thanks @Thomas
> patch: https://lore.proxmox.com/pve-devel/20250923093629.119418-1-s.shaji@proxmox.com/T/#t
> - Fixed file import error.
>
> [...]
Applied, thanks!
I changed the background color of the "pending" chip to orange in a follow up
commit though, red looked rather like an error to me.
[1/3] cleanup: run `dart format` on both qemu and lxc options page
commit: 9665ea62f85adcbd8e3ca2835cd1a65b661cb670
[2/3] feat: ui: add bottom sheet to change VMs/CTs options
commit: 3456772270bd26e20544f35c9881f68f0e6687c7
[3/3] cleanup: remove `PveConfigSwitchListTile` in favor of PveConfigListTile
commit: ada9279f4ae762a8473954b1a0c564b0b0c8f644
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-23 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 12:23 Shan Shaji
2025-09-23 12:23 ` [pve-devel] [PATCH pve_flutter_frontend v2 1/3] cleanup: run `dart format` on both qemu and lxc options page Shan Shaji
2025-09-23 12:23 ` [pve-devel] [PATCH pve_flutter_frontend v2 2/3] feat: ui: add bottom sheet to change VMs/CTs options Shan Shaji
2025-09-23 12:23 ` [pve-devel] [PATCH pve_flutter_frontend v2 3/3] cleanup: remove `PveConfigSwitchListTile` in favor of PveConfigListTile Shan Shaji
2025-09-23 12:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175863221771.3361632.13959607348963688505.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.