From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pmg-devel] applied: [PATCH pmg-api v2] fix #5438: api: mimetypes: allow admin users
Date: Tue, 23 Sep 2025 11:39:57 +0200 [thread overview]
Message-ID: <175862038354.1093161.8883286264958239612.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250923092611.5058-1-s.ivanov@proxmox.com>
On Tue, 23 Sep 2025 11:26:11 +0200, Stoiko Ivanov wrote:
> The list of mime-types recognized by the system is not really
> sensitive information. The call itself reads a directory from disk,
> which technically has a potential for causing load (but that should be
> cached after the first read).
>
> Allowing it for all authenticated backend users should be ok.
>
> [...]
Applied, thanks!
Reworded the commit message a bit to avoid a few redundant mentionings of
allowing it only for admins and the "Allowing it for all authenticated backend
users should be ok." was IMO slightly confusing, as it sorta implied to me that
this is the route you go, while then again mentioning admin-only in the next
paragraph. Anyhow, certainly somewhat nitpicking but tried to avoid that tiny
confusion potential.
[1/1] fix #5438: api: mimetypes: allow admin users
commit: da0e939b2c7913f90413f928ccc1eaa9c3bb70bd
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-09-23 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:26 [pmg-devel] " Stoiko Ivanov
2025-09-23 9:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175862038354.1093161.8883286264958239612.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.