From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pmg-devel] applied: [RFC pmg-api] pmgtunnel: do not set SIGCHLD handler
Date: Wed, 17 Sep 2025 12:33:10 +0200 [thread overview]
Message-ID: <175810517660.217321.2064899469933584876.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250818180714.22846-1-s.ivanov@proxmox.com>
On Mon, 18 Aug 2025 20:07:14 +0200, Stoiko Ivanov wrote:
> Drop the SIGCHLD handling in pmgtunnel, as it's not necessary and
> parts deeper in our code-base (e.g. PVE::Tools::run_command) rely on
> signals not being handled by the callers.
>
> In the case of pmgtunnel the signalhander (finish_children) simply
> wait(2)'s for all children (no matter if it's a ssh-tunnel process, or
> e.g. `ip link` being called to get network information), and clears
> the ssh-forwarded postgres socket, schedules a (delayed) restart, and
> logs an exit message for the ssh-tunnels.
>
> [...]
Applied, thanks!
[1/1] pmgtunnel: do not set SIGCHLD handler
commit: 415933fbb847587188169fe7c7b7b86feddc47a9
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-09-17 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 18:07 [pmg-devel] " Stoiko Ivanov
2025-08-19 10:13 ` Stefan Hanreich
2025-09-17 10:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175810517660.217321.2064899469933584876.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.