[pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog

* [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog
@ 2025-09-02 14:53 Maximiliano Sandoval
  2025-09-02 15:06 ` Daniel Kral
  2025-09-05 19:07 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Maximiliano Sandoval @ 2025-09-02 14:53 UTC (permalink / raw)
  To: pve-devel; +Cc: Lukas Wagner

This was displayed wrongly on the web UI and when calling

    pvesh get /nodes/localhost/apt/changelog

One potential example of such a package was bind9-dnsutils where the
character `ř` was rendered as `Å`.

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/APT.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index bd651ba1..4de4cb5b 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -7,6 +7,7 @@ use POSIX;
 use File::stat ();
 use IO::File;
 use File::Basename;
+use Encode qw(decode);
 
 use LWP::UserAgent;
 
@@ -418,7 +419,7 @@ __PACKAGE__->register_method({
             timeout => 10,
             logfunc => sub {
                 my $line = shift;
-                $output .= "$line\n";
+                $output .= decode('UTF-8', $line) . "\n";
             },
             noerr => 1,
         );
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread