[pdm-devel] applied-series: [PATCH datacenter-manager v5 00/10] implement more complex search syntax

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On Wed, 03 Sep 2025 15:09:16 +0200, Dominik Csapak wrote:
> this introduces a more complex search syntax for the resources api call
> and uses that with the dashboard to show relevant resources, e.g.
> when clicking on the remotes panel when there are failed remotes, it
> adds a search to the box that filters for offline remotes. Same
> for clicking on the running vm count, etc.
> 
> The syntax is a first draft of mine, we can still tweak and change it
> as we see fit, but it's a start.
> 
> [...]

Applied, thanks!

Some things that might still be improved:

- clear the field if one navigates away? Or at least make the text stand out
  less in that case, that probably would be good to do generally when the field
  is not active.

- the "click to search" is IMO a bit subtle and slightly surprising, especially
  when one doesn't click on the search icon or when there isn't even such a
  search icon. Don't get me wrong, I get where that idea come from and do not
  find it bad per se and have no definitive improvement suggestions ready, as
  it's not really a blocker or set in stone we can also wait on feedback or
  some real good idea, these things often just needs a bit of time actually
  using them.

[01/10] pdm-api-types: resources: add helper methods for fields
        commit: ac6a0c8bc64de7e11e5aac4589e46e84f4401f09
[02/10] lib: add pdm-search crate
        commit: 5bb918229abd1fd6d74c14855ca42e81455b45ae
[03/10] server: api: resources: add more complex filter syntax
        commit: 23639dc1814643b2dd4159f41f1a43b970195150
[04/10] ui: add possibility to insert into search box
        commit: 70faf3e26dda4d3d0e6fe2adf84929be3090029c
[05/10] ui: dashboard: remotes panel: open search on click
        commit: 43d3f0a8430180dea2b831da57fe91abfba72639
[06/10] ui: dashboard: guest panel: search for guest states when clicking on them
        commit: 5a4fb5d4d4a41d054275d3c3f2f621bc731b991c
[07/10] ui: dashboard: search for nodes when clicking on the nodes panel
        commit: 662af17ec051ad03b7e86252ddf7cf7c6e8f450a
[08/10] ui: search box: add clear trigger
        commit: 9dfa2c6480f202eeb281ee902d882f9c7d040a51
[09/10] ui: dashboard: guest panel: use `List` instead of `DataTable`
        commit: 811d430805438162d5ca5b31f8f347b896cfa3cf
[10/10] ui: dashboard: guest panel: add search icon for better discoverability
        commit: a1604aac7bfe5405354010b30d170ea7caeebc7f


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel