* [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
@ 2025-08-08 19:17 Kamil Trzcinski
2025-08-11 10:18 ` Fabian Grünbichler
2025-09-02 12:59 ` [pve-devel] applied: " Fabian Grünbichler
0 siblings, 2 replies; 5+ messages in thread
From: Kamil Trzcinski @ 2025-08-08 19:17 UTC (permalink / raw)
To: pve-devel
Submodules refer to private git+ssh url.
Use git.proxmox.com equivalents.
---
.gitmodules | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitmodules b/.gitmodules
index fd84194..0e2d332 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
[submodule "pwt-assets"]
path = pwt-assets
- url = gitolite3@proxdev.maurer-it.com:yew/proxmox-yew-widget-toolkit-assets
+ url = git://git.proxmox.com/git/ui/proxmox-yew-widget-toolkit-assets.git
[submodule "proxmox-api-types"]
path = proxmox-api-types
- url = gitolite3@proxdev.maurer-it.com:/rust/proxmox-api-types
+ url = git://git.proxmox.com/git/proxmox-api-types.git
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
2025-08-08 19:17 [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com Kamil Trzcinski
@ 2025-08-11 10:18 ` Fabian Grünbichler
2025-08-11 10:22 ` Kamil Trzciński
2025-08-14 13:20 ` Thomas Lamprecht
2025-09-02 12:59 ` [pve-devel] applied: " Fabian Grünbichler
1 sibling, 2 replies; 5+ messages in thread
From: Fabian Grünbichler @ 2025-08-11 10:18 UTC (permalink / raw)
To: Proxmox VE development discussion
On August 8, 2025 9:17 pm, Kamil Trzcinski wrote:
> Submodules refer to private git+ssh url.
> Use git.proxmox.com equivalents.
> ---
> .gitmodules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index fd84194..0e2d332 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,6 @@
> [submodule "pwt-assets"]
> path = pwt-assets
> - url = gitolite3@proxdev.maurer-it.com:yew/proxmox-yew-widget-toolkit-assets
> + url = git://git.proxmox.com/git/ui/proxmox-yew-widget-toolkit-assets.git
we often use relative urls that work for both servers, but I am not sure
whether that would work here..
@Dietmar: thoughts?
> [submodule "proxmox-api-types"]
> path = proxmox-api-types
> - url = gitolite3@proxdev.maurer-it.com:/rust/proxmox-api-types
> + url = git://git.proxmox.com/git/proxmox-api-types.git
> --
> 2.39.5
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
2025-08-11 10:18 ` Fabian Grünbichler
@ 2025-08-11 10:22 ` Kamil Trzciński
2025-08-14 13:20 ` Thomas Lamprecht
1 sibling, 0 replies; 5+ messages in thread
From: Kamil Trzciński @ 2025-08-11 10:22 UTC (permalink / raw)
To: Proxmox VE development discussion
Ah. In this case it would work, since both projects are in `ui/` subpath.
On Mon, 11 Aug 2025 at 12:19, Fabian Grünbichler
<f.gruenbichler@proxmox.com> wrote:
>
> On August 8, 2025 9:17 pm, Kamil Trzcinski wrote:
> > Submodules refer to private git+ssh url.
> > Use git.proxmox.com equivalents.
> > ---
> > .gitmodules | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/.gitmodules b/.gitmodules
> > index fd84194..0e2d332 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -1,6 +1,6 @@
> > [submodule "pwt-assets"]
> > path = pwt-assets
> > - url = gitolite3@proxdev.maurer-it.com:yew/proxmox-yew-widget-toolkit-assets
> > + url = git://git.proxmox.com/git/ui/proxmox-yew-widget-toolkit-assets.git
>
> we often use relative urls that work for both servers, but I am not sure
> whether that would work here..
>
> @Dietmar: thoughts?
>
> > [submodule "proxmox-api-types"]
> > path = proxmox-api-types
> > - url = gitolite3@proxdev.maurer-it.com:/rust/proxmox-api-types
> > + url = git://git.proxmox.com/git/proxmox-api-types.git
> > --
> > 2.39.5
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >
> >
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
2025-08-11 10:18 ` Fabian Grünbichler
2025-08-11 10:22 ` Kamil Trzciński
@ 2025-08-14 13:20 ` Thomas Lamprecht
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2025-08-14 13:20 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
On 11/08/2025 12:18, Fabian Grünbichler wrote:
> On August 8, 2025 9:17 pm, Kamil Trzcinski wrote:
>> Submodules refer to private git+ssh url.
>> Use git.proxmox.com equivalents.
>> ---
>> .gitmodules | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.gitmodules b/.gitmodules
>> index fd84194..0e2d332 100644
>> --- a/.gitmodules
>> +++ b/.gitmodules
>> @@ -1,6 +1,6 @@
>> [submodule "pwt-assets"]
>> path = pwt-assets
>> - url = gitolite3@proxdev.maurer-it.com:yew/proxmox-yew-widget-toolkit-assets
>> + url = git://git.proxmox.com/git/ui/proxmox-yew-widget-toolkit-assets.git
>
> we often use relative urls that work for both servers, but I am not sure
> whether that would work here..
>
> @Dietmar: thoughts?
It's much simpler to just use the absolute URL, that always work.
The relative path is an optimization and can still be enabled by
adapting the path manually locally, but in anyway that's less a
problem compared to not being able to clone at all without hacking
around, which is a horrible experience...
>> [submodule "proxmox-api-types"]
>> path = proxmox-api-types
>> - url = gitolite3@proxdev.maurer-it.com:/rust/proxmox-api-types
>> + url = git://git.proxmox.com/git/proxmox-api-types.git
>> --
>> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied: [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
2025-08-08 19:17 [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com Kamil Trzcinski
2025-08-11 10:18 ` Fabian Grünbichler
@ 2025-09-02 12:59 ` Fabian Grünbichler
1 sibling, 0 replies; 5+ messages in thread
From: Fabian Grünbichler @ 2025-09-02 12:59 UTC (permalink / raw)
To: pve-devel, Kamil Trzcinski
On Fri, 08 Aug 2025 21:17:44 +0200, Kamil Trzcinski wrote:
> Submodules refer to private git+ssh url.
> Use git.proxmox.com equivalents.
>
>
Applied, thanks!
[1/1] fix submodules paths to work with git.proxmox.com
commit: ca2eb095c9a27bed0ed35871053d2e9b12436899
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-09-02 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-08 19:17 [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com Kamil Trzcinski
2025-08-11 10:18 ` Fabian Grünbichler
2025-08-11 10:22 ` Kamil Trzciński
2025-08-14 13:20 ` Thomas Lamprecht
2025-09-02 12:59 ` [pve-devel] applied: " Fabian Grünbichler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.