all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ha: rule edit: fix enabling ha rules which are disabled
@ 2025-09-01  8:29 Daniel Kral
  2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kral @ 2025-09-01  8:29 UTC (permalink / raw)
  To: pve-devel

Setting the `disable` property to 0 does not make a HA rule being
enabled anymore since a change in the HA Manager, so explicitly delete
the `disable` property when the HA rule should be enabled.

Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 www/manager6/ha/RuleEdit.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ha/RuleEdit.js b/www/manager6/ha/RuleEdit.js
index 9ecebd6d..c65c5c97 100644
--- a/www/manager6/ha/RuleEdit.js
+++ b/www/manager6/ha/RuleEdit.js
@@ -27,7 +27,13 @@ Ext.define('PVE.ha.RuleInputPanel', {
             values.rule = 'ha-rule-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13);
         }
 
-        values.disable = values.enable ? 0 : 1;
+        if (values.enable) {
+            if (!me.isCreate) {
+                Proxmox.Utils.assemble_field_data(values, { delete: 'disable' });
+            }
+        } else {
+            values.disable = 1;
+        }
         delete values.enable;
 
         values.resources = me.formatResourceListString(values.resources);

-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-02 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-01  8:29 [pve-devel] [PATCH manager] ha: rule edit: fix enabling ha rules which are disabled Daniel Kral
2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal