From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES manager 0/2] lvm config: check that --clear-needs-check-flag is set if there is a thin_check_options override
Date: Fri, 08 Aug 2025 16:19:09 +0200 [thread overview]
Message-ID: <1754662620.dr8couq0mf.astroid@yuna.none> (raw)
In-Reply-To: <20250808140419.119992-1-f.ebner@proxmox.com>
On August 8, 2025 4:03 pm, Fiona Ebner wrote:
> Quoting the commit message from [0] verbatim:
>
>> thin_check v1.0.x reveals data block ref count issue that is not being
>> detected by previous versions, which blocks the pool from activation if
>> there are any leaked blocks. To reduce potential user complaints on
>> inactive pools after upgrading and also maintain backward compatibility
>> between LVM and older thin_check, we decided to adopt the 'auto-repair'
>> functionality in the --clear-needs-check-flag option, rather than
>> passing --auto-repair from lvm.conf.
>
> Unfortunately, there was already a user report without the override
> [1], so this might not be the only issue. It's still worth warning
> users about this though.
>
> NOTE: For stable-8 the version check in d/postinst needs to be adapted
> or maybe we want to run the check always there?
I don't think we need to run it there at all, do we? the problematic
behaviour only comes with trixie's version of thin_check AFAIU?
> [0]: https://github.com/device-mapper-utils/thin-provisioning-tools/commit/eb28ab94
> [1]: https://forum.proxmox.com/threads/169356/post-789894
>
>
> Fiona Ebner (2):
> 8 to 9: lvm config: check that --clear-needs-check-flag is set if
> there is a thin_check_options override
> d/postinst: lvm config: check that --clear-needs-check-flag is set if
> there is a thin_check_options override
>
> PVE/CLI/pve8to9.pm | 27 +++++++++++++++++++++++++++
> debian/postinst | 8 ++++++++
> 2 files changed, 35 insertions(+)
>
> --
> 2.47.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-08 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 14:03 Fiona Ebner
2025-08-08 14:03 ` [pve-devel] [PATCH manager 1/2] 8 to 9: " Fiona Ebner
2025-08-08 14:03 ` [pve-devel] [PATCH manager 2/2] d/postinst: " Fiona Ebner
2025-08-08 14:19 ` Fabian Grünbichler [this message]
2025-08-08 14:23 ` [pve-devel] [PATCH-SERIES manager 0/2] " Fiona Ebner
2025-08-08 14:19 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1754662620.dr8couq0mf.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.