From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-common v2] inotify: interfaces: also set type 'bridge' for empty bridges
Date: Fri, 8 Aug 2025 11:59:27 +0200 [thread overview]
Message-ID: <175464715749.305946.15966326218560304138.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250808093203.17668-1-h.laimer@proxmox.com>
On Fri, 08 Aug 2025 11:32:03 +0200, Hannes Laimer wrote:
> If a bridge has `bridge_ports` set to `none` we just skip the field.
> Later we use the existance of the field to determine whether the type
> should be `bridge`. This led to bridges without `bridge_ports` not
> being recognized as bridges.
>
> In the `/nodes/{}/network` endpiont we do permission checks for
> bridges, and if interfaces were missing the type=bridge field no
> permission checks were done. This led to interfaces being returned
> even if the user did not have permission to access them.
>
> [...]
Applied, thanks!
Added a small follow-up to make it a bit more explicit/easier to read.
[1/1] inotify: interfaces: also set type 'bridge' for empty bridges
commit: 1555ab5d76d8675e1f16a197ee744cee33200a21
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-08 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 9:32 [pve-devel] " Hannes Laimer
2025-08-08 9:59 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175464715749.305946.15966326218560304138.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.