From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] qm: cleanup: do dbus-vmstate safety cleanup silently when requested
Date: Mon, 4 Aug 2025 16:08:47 +0200 [thread overview]
Message-ID: <175431652628.1516560.4613673992169983103.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250804133002.1625925-1-c.heiss@proxmox.com>
On Mon, 04 Aug 2025 15:29:56 +0200, Christoph Heiss wrote:
> First, moving to vm_stop_cleanup(), which is a better fit for this.
> It gets called by the cleanup API method in case of unclean shutdown or
> from inside the guest.
>
> In every case, the dbus-vmstate daemon should _never_ be running at this
> point, as it is started only before migration and stopped directly after
> migration, before vm_stop_cleanup() is even called. So it should only be
> left running in case of a crash during migration.
>
> [...]
Applied, tried to untangle the subject a bit, thanks!
[1/1] vmstate: improve cleaning up dbus-vmstate and avoid spurious warning
commit: 067a0f55bbf155936861d8844c91dfc16b883c1d
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-04 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:29 Christoph Heiss
2025-08-04 14:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175431652628.1516560.4613673992169983103.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.