From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com,
pmg-devel@lists.proxmox.com,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config
Date: Thu, 31 Jul 2025 13:34:31 +0200 [thread overview]
Message-ID: <175396166927.943348.2726142111644567603.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250731113015.148881-1-c.ebner@proxmox.com>
On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
>
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
>
> [...]
Applied, thanks!
[1/1] network edit: fix hiding of altnames field if disabled by config
commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com,
pmg-devel@lists.proxmox.com,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config
Date: Thu, 31 Jul 2025 13:34:31 +0200 [thread overview]
Message-ID: <175396166927.943348.2726142111644567603.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250731113015.148881-1-c.ebner@proxmox.com>
On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
>
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
>
> [...]
Applied, thanks!
[1/1] network edit: fix hiding of altnames field if disabled by config
commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com,
pmg-devel@lists.proxmox.com,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pmg-devel] applied: [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config
Date: Thu, 31 Jul 2025 13:34:31 +0200 [thread overview]
Message-ID: <175396166927.943348.2726142111644567603.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250731113015.148881-1-c.ebner@proxmox.com>
On Thu, 31 Jul 2025 13:30:15 +0200, Christian Ebner wrote:
> Commit 691f530d ("network: optionally show alternative interface
> names") introduced the optional altnames field in the network edit
> grid. The chosen default configuration however does not even add the
> field, therefore setting it to hidden if no altnames data is present
> cannot work.
>
> Fix this by only hiding the field if it was actually configured to be
> shown in the first place.
>
> [...]
Applied, thanks!
[1/1] network edit: fix hiding of altnames field if disabled by config
commit: c3bb1497d7f1605a2fe04e89a42a38c0292d8741
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-07-31 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 11:30 [pbs-devel] " Christian Ebner
2025-07-31 11:30 ` [pmg-devel] " Christian Ebner
2025-07-31 11:30 ` [pve-devel] " Christian Ebner
2025-07-31 11:34 ` Thomas Lamprecht [this message]
2025-07-31 11:34 ` [pmg-devel] applied: " Thomas Lamprecht
2025-07-31 11:34 ` [pve-devel] applied: [pmg-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175396166927.943348.2726142111644567603.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.