From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] plugin: lvm: volume snapshot info: untaint snapshot filename
Date: Thu, 31 Jul 2025 09:20:05 +0200 [thread overview]
Message-ID: <175394639682.545443.12653711389066340381.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250731071306.11777-1-f.weber@proxmox.com>
On Thu, 31 Jul 2025 09:13:02 +0200, Friedrich Weber wrote:
> Without untainting, offline-deleting a volume-chain snapshot on an LVM
> storage via the GUI can fail with an "Insecure dependecy in exec
> [...]" error, because volume_snapshot_delete uses the filename its
> qemu-img invocation.
>
> Commit 93f0dfb ("plugin: volume snapshot info: untaint snapshot
> filename") fixed this already for the volume_snapshot_info
> implementation of the Plugin base class, but missed that the LVM
> plugin overrides the method and was still missing the untaint.
>
> [...]
Applied, thanks!
[1/1] plugin: lvm: volume snapshot info: untaint snapshot filename
commit: 92efe5c6cb9904ebf7bbb7f8d690ac80e7c91e23
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-31 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 7:13 [pve-devel] " Friedrich Weber
2025-07-31 7:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175394639682.545443.12653711389066340381.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.