From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/1] qemu-server: exit delete early if we cannot find a snapshot
Date: Wed, 30 Jul 2025 18:32:34 +0200 [thread overview]
Message-ID: <175389312126.164929.9126961189112060772.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250730103705.98313-3-s.sterz@proxmox.com>
On Wed, 30 Jul 2025 12:37:06 +0200, Shannon Sterz wrote:
> Die if the list of snapshots returned by `volume_snapshot_info` does
> not contain the snapshot we are trying to delete.
>
> Previously it was just assumed that the snapshot would be present,
> leading to the entry in the list being autoviviefied by the following
> lines of code. Hence, we tried to commit nonexistent snapshot states
> here, as both `$parentsnap` and `$childsnap` would be undefined.
>
> [...]
Applied, this one thanks! I also included the volid in the error
message for more context.
[1/1] qemu-server: exit delete early if we cannot find a snapshot
commit: 6b7598a643a2137c8ce7c73bb928b6d390a20f97
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-30 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 10:37 [pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore Shannon Sterz
2025-07-30 10:37 ` [pve-devel] [PATCH qemu-server 1/1] qemu-server: exit delete early if we cannot find a snapshot Shannon Sterz
2025-07-30 16:32 ` Fiona Ebner [this message]
2025-07-30 15:43 ` [pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175389312126.164929.9126961189112060772.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.