From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-manager v2 1/2] pvestatd: pull metric: use ip link to detect physical interfaces
Date: Tue, 29 Jul 2025 21:21:24 +0200 [thread overview]
Message-ID: <175381688321.2683022.7251869854078239677.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250729171649.708219-3-s.hanreich@proxmox.com>
On Tue, 29 Jul 2025 19:16:44 +0200, Stefan Hanreich wrote:
> pve-common now allows arbitrary names for physical interfaces, without
> being restricted by PHYSICAL_NIC_RE. In order to detect physical
> interfaces, pvestatd now needs to query 'ip link' for the type of an
> interface instead of relying on the regular expression.
>
> On the receiving end, PullMetric cannot consult 'ip link' for
> determining which interface is physical or not. To work around that,
> introduce a new type key, that carries information about the type of
> an interface. When aggregating the metrics, PullMetric can now read
> this additional parameter, to infer the type of the interface (either
> physical or virtual).
>
> [...]
Applied, thanks!
I added a time-based expiry check to re-cache this every 15 minutes in a follow
up, it's a very simple check and this way we converge relatively fast while not
doing that many updates.
[1/2] pvestatd: pull metric: use ip link to detect physical interfaces
commit: 83d0b982e6ad498031f0f1d97511b441c98a7706
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-29 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 17:16 [pve-devel] [PATCH common/manager v2 0/3] arbitrary prefixes for pinning network interfaces Stefan Hanreich
2025-07-29 17:16 ` [pve-devel] [PATCH pve-common v2 1/1] inotify/interfaces: use ip link for detecting physical interfaces Stefan Hanreich
2025-07-29 19:21 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-29 17:16 ` [pve-devel] [PATCH pve-manager v2 1/2] pvestatd: pull metric: use ip link to detect " Stefan Hanreich
2025-07-29 19:21 ` Thomas Lamprecht [this message]
2025-07-29 17:16 ` [pve-devel] [PATCH pve-manager v2 2/2] network-interface-pinning: allow arbitrary names Stefan Hanreich
2025-07-29 19:21 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175381688321.2683022.7251869854078239677.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.