all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, "nansen.su" <nansen.su@sianit.com>
Subject: [pve-devel] applied: [PATCH pve-manager v3] metrics add OpenTelemetry support
Date: Tue, 29 Jul 2025 18:40:25 +0200	[thread overview]
Message-ID: <175380722483.2503338.9448629273577393473.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250722095526.4164885-2-nansen.su@sianit.com>

On Tue, 22 Jul 2025 17:55:27 +0800, nansen.su wrote:
>   Add OpenTelemetry metric type classification to fix Prometheus compatibility
> 
>   Problem
> 
>   The OpenTelemetry plugin was exporting all metrics as gauge type, causing Prometheus/Grafana to show warnings like:
>   PromQL info: metric might not be a counter, name does not end in total/sum/_count/_bucket: "proxmox_node_network_transmit_bytes"
> 
> [...]

Applied, thanks!

FYI:
I reworded the commit message a bit, as you mostly used it as development
changelog, so I copied over some info from the v1 patch.
Also automatically reformated the code using the `make tidy` target to avoid
various whitespace and indentaion issues.

[1/1] metrics add OpenTelemetry support
      commit: 523050865a2047d514275608d90afee58aeed1b6


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-07-29 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  9:55 [pve-devel] " nansen.su
2025-07-29 16:40 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175380722483.2503338.9448629273577393473.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=nansen.su@sianit.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal