From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES qemu-server 0/3] fix migration status handling (for QEMU 10.0+)
Date: Tue, 29 Jul 2025 08:05:22 +0200 [thread overview]
Message-ID: <175376912047.1862573.10339598802085429511.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250728143042.103045-1-f.ebner@proxmox.com>
On Mon, 28 Jul 2025 16:30:30 +0200, Fiona Ebner wrote:
> There are some states that 'query-migrate' can return [0] which are
> not properly handled by Proxmox VE yet.
>
> In particular, as reported in the community forum [1], with QEMU 10.0,
> the 'device' status can be present with migration parameters used by
> Proxmox VE.
>
> [...]
Got already positive feedback in the forum, so: Applied, thanks!
FWIW, might be worth to transform the regex to a hash and lc() the key before
checking. Seems also a bit odd to me that the regex is using multiline, is that
really needed here? But all pre-existing and not really hurting, so really not
high priority to check.
[1/3] migration: status check: order states in regex alphabetically
commit: d3842716a1156a99b937af9c8f89ea43defff13d
[2/3] migration: handle 'device' migration status newly present in QEMU 10.0+
commit: 34d03f914821479515272df79792ab3ae17a1c06
[3/3] migration: handle 'cancelling' and 'wait-unplug' status
commit: c106f1326daec73677aa33ec5091ac70fe9e6789
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-29 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 14:30 Fiona Ebner
2025-07-28 14:30 ` [pve-devel] [PATCH qemu-server 1/3] migration: status check: order states in regex alphabetically Fiona Ebner
2025-07-28 14:30 ` [pve-devel] [PATCH qemu-server 2/3] migration: handle 'device' migration status newly present in QEMU 10.0+ Fiona Ebner
2025-07-28 14:30 ` [pve-devel] [PATCH qemu-server 3/3] migration: handle 'cancelling' and 'wait-unplug' status Fiona Ebner
2025-07-29 6:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175376912047.1862573.10339598802085429511.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.