[pve-devel] [PATCH cluster/manager 0/2] ui: add datacenter replication network option

[pve-devel] [PATCH cluster/manager 0/2] ui: add datacenter replication network option

[Maximiliano Sandoval]

This is a followup of
https://lore.proxmox.com/all/20250612132951.449798-2-m.sandoval@proxmox.com/T/#u.
We expose the option in the UI and we fix an issue where the config would be generated wrongly, e.g.

    replication: type=secure,network=10.10.10.161/24

instead of :

    replication: secure,network=10.10.10.161/24

cluster:

Maximiliano Sandoval (1):
  datacenter config: Actually write the replication config

 src/PVE/DataCenterConfig.pm | 4 ++++
 1 file changed, 4 insertions(+)


manager:

Maximiliano Sandoval (1):
  ui: dc/options: allow to edit cluster wide replication settings

 www/manager6/dc/OptionView.js | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)


Summary over all repositories:
  2 files changed, 32 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH cluster 1/1] datacenter config: Actually write the replication config

[Maximiliano Sandoval]

We get the following error without this patch:

```
$ pvesh set /cluster/options
400 validation error in '/etc/pve/datacenter.cfg'
replication: type check ('string') failed - got HASH
```

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/DataCenterConfig.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index 3d15643..c6d56c1 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
@@ -615,6 +615,10 @@ sub write_datacenter_config {
         $cfg->{migration} = PVE::JSONSchema::print_property_string($migration, $migration_format);
     }
 
+    if (ref(my $replication = $cfg->{replication})) {
+        $cfg->{replication} = PVE::JSONSchema::print_property_string($replication, $replication_format);
+    }
+
     if (defined(my $next_id = $cfg->{'next-id'})) {
         $next_id = parse_property_string($next_id_format, $next_id) if !ref($next_id);
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster 1/1] datacenter config: Actually write the replication config

[Thomas Lamprecht]

On Fri, 18 Jul 2025 10:13:48 +0200, Maximiliano Sandoval wrote:
> We get the following error without this patch:
> 
> ```
> $ pvesh set /cluster/options
> 400 validation error in '/etc/pve/datacenter.cfg'
> replication: type check ('string') failed - got HASH
> ```
> 
> [...]

Applied, thanks!

[1/1] datacenter config: Actually write the replication config
      commit: 127cd9be3b2cbd9bb13a50d05971c9b289d75f79


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/1] ui: dc/options: allow to edit cluster wide replication settings

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/dc/OptionView.js | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 94f299a3..772c5379 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -128,6 +128,34 @@ Ext.define('PVE.dc.OptionView', {
                 },
             ],
         });
+        me.add_inputpanel_row('replication', gettext('Replication Settings'), {
+            renderer: PVE.Utils.render_as_property_string,
+            labelWidth: 120,
+            url: '/api2/extjs/cluster/options',
+            defaultKey: 'type',
+            items: [
+                {
+                    xtype: 'displayfield',
+                    name: 'type',
+                    fieldLabel: gettext('Type'),
+                    value: 'secure',
+                    submitValue: true,
+                },
+                {
+                    xtype: 'proxmoxNetworkSelector',
+                    name: 'network',
+                    fieldLabel: gettext('Network'),
+                    value: null,
+                    emptyText: Proxmox.Utils.defaultText,
+                    autoSelect: false,
+                    skipEmptyText: true,
+                    editable: true,
+                    notFoundIsValid: true,
+                    vtype: 'IP64CIDRAddress',
+                    type: 'include_sdn',
+                },
+            ],
+        });
         me.add_inputpanel_row('ha', gettext('HA Settings'), {
             renderer: PVE.Utils.render_dc_ha_opts,
             labelWidth: 120,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 1/1] ui: dc/options: allow to edit cluster wide replication settings

[Thomas Lamprecht]

On Fri, 18 Jul 2025 10:13:49 +0200, Maximiliano Sandoval wrote:
> 


Applied, thanks!

[1/1] ui: dc/options: allow to edit cluster wide replication settings
      commit: 2064c0db18f110ac3498901ea4b79e8de53511bf


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel