[pve-devel] [PATCH widget-toolkit v2] fix #6312: limit consent window to viewport size

[pve-devel] [PATCH widget-toolkit v2] fix #6312: limit consent window to viewport size

[Dominik Csapak]

The consent window will try to size itself according to the max/min
constraints set, but those might be too large for some viewport sizes.

Since it's not possible to set those to relative viewport sizes (ExtJS
does it's own layout, so we can't use CSS), we have to save the original
size and on resize of the viewport limit ourselves to that (minus 10 px
safety margin).

Even with that the window will adhere to the set constraint sizes,
but it should be viewable with any sensible display/viewport size.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* use afterComponentLayout instead of aferrender event, since the full
  layouting including sizes + constraints is done afterwards
* don't manually apply/check constraints, since that is done
  by the layouting already
* adapt commit message

 src/window/ConsentModal.js | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/src/window/ConsentModal.js b/src/window/ConsentModal.js
index 2826899..6e2f505 100644
--- a/src/window/ConsentModal.js
+++ b/src/window/ConsentModal.js
@@ -32,5 +32,35 @@ Ext.define('Proxmox.window.ConsentModal', {
 	    text: gettext('OK'),
 	},
     ],
+
+    onResize: function() {
+	let me = this;
+	let viewportSize = Ext.getBody().getViewSize();
+
+	let originalSize = me.originalSize ?? me.getSize();
+	// limit to viewport size - 10px for safety
+	let newSize = {
+	    width: Math.min(originalSize.width, viewportSize.width - 10),
+	    height: Math.min(originalSize.height, viewportSize.height - 10),
+	};
+
+	me.setSize(newSize);
+	me.alignTo(Ext.getBody(), 'c-c');
+    },
+
+    afterComponentLayout: function(width, height) {
+	let me = this;
+	me.originalSize ??= { width, height };
+    },
+
+    listeners: {
+	resize: 'onResize',
+    },
+
+    initComponent: function() {
+	let me = this;
+	me.callParent();
+	me.mon(Ext.getBody(), 'resize', me.onResize, me);
+    },
 });
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit v2] fix #6312: limit consent window to viewport size

[Thomas Lamprecht]

On Thu, 15 May 2025 10:02:14 +0200, Dominik Csapak wrote:
> The consent window will try to size itself according to the max/min
> constraints set, but those might be too large for some viewport sizes.
> 
> Since it's not possible to set those to relative viewport sizes (ExtJS
> does it's own layout, so we can't use CSS), we have to save the original
> size and on resize of the viewport limit ourselves to that (minus 10 px
> safety margin).
> 
> [...]

Applied, thanks!

[1/1] fix #6312: limit consent window to viewport size
      commit: 5b329a62352a14544b313fd5762d782efa480231


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel